Walletwasabi: Typing a recovery word the suggestion doesn't disappear after the word is completed.

[danwalmsley]

General Description

Typing a recovery word the suggestion doesn't disappear after the word is completed.

This is an issue on master but not in the current release.

[yahiheb]

I think the current behavior on master is the correct one, because if there is no suggestion then it is like the word doesn't exist in the world list.

[danwalmsley]

@yahiheb all I know is that it changed at some point... possibly someone changed this purposefully, but would like to find out if it was... or if it was an accidental change.

[MaxHillebrand]

this is a duplicate of an issue that I cannot find just now... [it was in the v1.1.12 review game]

A word CAN appear more than once in the recovery words, according to the BIP.

Thus, the current behavior is expected and correct.

[yahiheb]

@MaxHillebrand It is not a duplicate, this issue is about the suggestion not disappearing when a whole word is typed and the other issue (4105) was about not suggesting a word again if it was already chosen.

@yahiheb all I know is that it changed at some point... possibly someone changed this purposefully, but would like to find out if it was... or if it was an accidental change.

@danwalmsley It turned out that the PR #4106 which fixed the issue that Max mentioned is the one that changed the behavior.
But I think it is now working as it should so it is a good coincidence.

[MaxHillebrand]

thanks @yahiheb for the clarification - yes you are correct I think!

does the word disappear when you type in a space?

[soosr]

@MaxHillebrand

No, it doesn't. The suggestion word still there, it only disappears when the user clicks on it.
IMO, it should disappear after the space char because it means that the next word coming so there is no place for the suggestion.