Walletwasabi: Display address on ColdCard throws an exception on TestNet

[molnard]

General Description

This happens only on TestNet. The address is displayed on the device but instead of tb1 it starts with bc1. After the operation was successful CC sends back the displayed address bc1 that cannot be parsed as a TestNet address and Wasabi throws an exception. The --testnet flag passed when calling the HWI request. Probably CC is figuring out the network from the Path that is a MainNet path according to https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki.

How To Reproduce?

1. Open CC wallet
2. Go to receive
3. Generate address
4. Display address on HW

Screenshots

Operating System

win10x64

Logs

2020-07-16 15:54:35 INFO    TransactionFactory (108)    Calculating dynamic transaction fee...
2020-07-16 15:54:35 INFO    TransactionFactory (176)    Fee: 178 Satoshi.
2020-07-16 15:54:35 INFO    TransactionFactory (179)    Estimated tx size: 178 vBytes.
2020-07-16 15:54:35 INFO    TransactionFactory (219)    Signing transaction...
2020-07-16 15:54:35 INFO    TransactionFactory (307)    Transaction is successfully built: 4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4.
2020-07-16 15:55:05 INFO    TransactionBroadcaster (46) Trying to broadcast transaction with random node (::ffff:193.198.34.24):4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4.
2020-07-16 15:55:05 INFO    P2pBehavior (113)   Successfully served transaction to node ([::ffff:193.198.34.24]:18333): 4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4.
2020-07-16 15:55:06 INFO    TransactionBroadcaster (70) Disconnected node: ::ffff:193.198.34.24. Successfully broadcasted transaction: 4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4.
2020-07-16 15:55:09 INFO    Global (620)    Transaction Notification (Information): Self Spend - Mining Fee: 0.00000178 BTC - 4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4
2020-07-16 15:55:09 INFO    TransactionBroadcaster (83) Transaction is successfully propagated: 4315bde7e8d9da453c49e9073945c58d83ead37d99d16422f94291f12cafd7f4.
2020-07-16 15:55:29 ERROR   AddressViewModel (138)  System.FormatException: Wrong network.
   at WalletWasabi.Hwi.Parsers.HwiParser.ParseAddress(String json, Network network) in C:\work\WalletWasabi\WalletWasabi\Hwi\Parsers\HwiParser.cs:line 193
   at WalletWasabi.Hwi.HwiClient.DisplayAddressImplAsync(Nullable`1 deviceType, String devicePath, Nullable`1 fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 169
   at WalletWasabi.Hwi.HwiClient.DisplayAddressAsync(HDFingerprint fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 158
   at WalletWasabi.Gui.ViewModels.AddressViewModel.<>c__DisplayClass8_0.<<-ctor>b__15>d.MoveNext() in C:\work\WalletWasabi\WalletWasabi.Gui\ViewModels\AddressViewModel.cs:line 107
2020-07-16 15:56:01 ERROR   AddressViewModel (138)  System.FormatException: Wrong network.
   at WalletWasabi.Hwi.Parsers.HwiParser.ParseAddress(String json, Network network) in C:\work\WalletWasabi\WalletWasabi\Hwi\Parsers\HwiParser.cs:line 193
   at WalletWasabi.Hwi.HwiClient.DisplayAddressImplAsync(Nullable`1 deviceType, String devicePath, Nullable`1 fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 169
   at WalletWasabi.Hwi.HwiClient.DisplayAddressAsync(HDFingerprint fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 158
   at WalletWasabi.Gui.ViewModels.AddressViewModel.<>c__DisplayClass8_0.<<-ctor>b__15>d.MoveNext() in C:\work\WalletWasabi\WalletWasabi.Gui\ViewModels\AddressViewModel.cs:line 107
2020-07-16 15:58:39 ERROR   AddressViewModel (138)  System.FormatException: Wrong network.
   at WalletWasabi.Hwi.Parsers.HwiParser.ParseAddress(String json, Network network) in C:\work\WalletWasabi\WalletWasabi\Hwi\Parsers\HwiParser.cs:line 193
   at WalletWasabi.Hwi.HwiClient.DisplayAddressImplAsync(Nullable`1 deviceType, String devicePath, Nullable`1 fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 169
   at WalletWasabi.Hwi.HwiClient.DisplayAddressAsync(HDFingerprint fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 158
   at WalletWasabi.Gui.ViewModels.AddressViewModel.<>c__DisplayClass8_0.<<-ctor>b__15>d.MoveNext() in C:\work\WalletWasabi\WalletWasabi.Gui\ViewModels\AddressViewModel.cs:line 107
2020-07-16 16:00:18 ERROR   AddressViewModel (138)  System.Threading.Tasks.TaskCanceledException: A task was canceled.
2020-07-16 16:00:49 ERROR   AddressViewModel (138)  System.FormatException: Wrong network.
   at WalletWasabi.Hwi.Parsers.HwiParser.ParseAddress(String json, Network network) in C:\work\WalletWasabi\WalletWasabi\Hwi\Parsers\HwiParser.cs:line 193
   at WalletWasabi.Hwi.HwiClient.DisplayAddressImplAsync(Nullable`1 deviceType, String devicePath, Nullable`1 fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 169
   at WalletWasabi.Hwi.HwiClient.DisplayAddressAsync(HDFingerprint fingerprint, KeyPath keyPath, CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\Hwi\HwiClient.cs:line 158
   at WalletWasabi.Gui.ViewModels.AddressViewModel.<>c__DisplayClass8_0.<<-ctor>b__15>d.MoveNext() in C:\work\WalletWasabi\WalletWasabi.Gui\ViewModels\AddressViewModel.cs:line 107

Wasabi Version

master

[MaxHillebrand]

I guess this is because Wasabi uses the 84/0/0/0 path for testnet too, which is non-standard.

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[molnard]

Wontfix, same reason https://github.com/zkSNACKs/WalletWasabi/pull/4010