Walletwasabi: [v1.1.11] Multiple hardware wallets bug

[RiccardoMasutti]

General Description

If in the past I inserted a Trezor Model One (so there is already a wallet file called Trezor_10.json and now I insert another (new) Trezor Model One and try to open it, it does not create a new Trezor_11.json file and it does not open the right wallet.
It opens the wrong old Trezor_10.json.

The same applies for Trezor Model T.
It's a huge problem because it doesn't allow you to use two identical hardware wallet models

How To Reproduce?

1. Go to Hardware Wallet > Search Hardware Wallet
2. Load the first Wallet Trezor_1
3. Go to Hardware Wallet > Search Hardware Wallet
4. Load a different/new Trezor_1
5. It does not generate a new Wallet (which ideally should be called Trezor_11, but opens the wrong wallet (the old Trezor_10 of the first Model One)

Operating System

Tails v4.4.1

Wasabi Version

Wasabi v1.1.11rc1

[molnard]

It tried it with two Trezor_T - it works for me.

Wasabi identifies the corresponding wallet by ExtPubKey. It can load the wrong wallet only it the ExtPubKeys are identical.

Can you check it in the wallet files?

[RiccardoMasutti]

ExtPubKeys are different.

Please follow this method and check again:

1. Delete all Trezor_*.json wallets
2. Manually create a new Trezor_T0.json via Wasabi
3. Connect a new Trezor T hardware wallet
4. Load the hardware wallet

In my case it opens the wrong old wallet

[molnard]

I am getting this one. Checking the problem - might be critical - 3 points!

[molnard]

I found the bug. Wasabi tries to recover it from the WalletBackup dir, but there is a naming collision. This is caused because you only deleted the wallet from the Wallets folder.
Still, this is an issue - however, I consider it as not as critical to include in the release.

[RiccardoMasutti]

I found the bug. Wasabi tries to recover it from the WalletBackup dir, but there is a naming collision. This is caused because you only deleted the wallet from the Wallets folder.
Still, this is an issue - however, I consider it as not as critical to include in the release.

There are multiple issues

[RiccardoMasutti]

Seems it's fixed now.