Walletwasabi: Wallet not recovered from Backup

[MaxHillebrand]

How To Reproduce?

1. Delete wallet file in /client/Wallets/
2. Start Wasabi
3. Wallet is NOT restored from client/WalletBackup/ and it is not shown in the GUI.

Version

Qubes 4 Debian 10 & Fedora 30
Wasabi master 3e83310a20f513877b6b34a2b359b158a1e40313

[yahiheb]

I confirm this, but this is not working even in 1.1.10.3.

[RiccardoMasutti]

I can reproduce on Tails 4.4.1.
Fortunately I have seen that it has already been reported.

[lontivero]

The wallets in the WalletBackups folder are just in case the user deletes a wallet accidentally or the original file is somehow corrupted. The wallets in the WalletBackups folders should not be listed because it is not an alternative place where wallets can be persisted or picked up from.

I confirm this, but this is not working even in 1.1.10.3

You will not find any version where this "works" as described in this issue.

[lontivero]

This question comes from a different issue:

@lontivero how do you remember? What was the original purpose of this feature?

The feature was introduced by @nopara73 in order to prevent catastrophic situations in case the wallet file gets corrupted. https://github.com/zkSNACKs/WalletWasabi/issues/625

The idea was to automatically keep backups of the wallets and in case one wallet got corrupted for whatever reason then wasabi can detect that problem and autofix it by restoring the backuped wallet.

That's why I said WalletBackup folder is to save wallets backups, and eventually restore one that was corrupted, but it is in no case al alternative place to take wallets from.