Walletwasabi: Daemon command doesn't work

[yahiheb]

Running dotnet run -- mix --wallet:MyWalletName on master I get this:

Password: 2020-03-14 19:58:08 INFO      Daemon (133)    Daemon stopped.
commands: There was a problem interpreting the command, please review it.
2020-03-14 19:58:09 DEBUG       MixerCommand (53)       System.InvalidOperationException: Cannot read keys when either application does not have a console or when console input has been redirected. Try Console.Read.
   at System.ConsolePal.ReadKey(Boolean intercept)
   at System.Console.ReadKey(Boolean intercept)
   at WalletWasabi.Helpers.PasswordConsole.ReadPassword() in C:\Users\RESEAU\Desktop\WalletWasabi\WalletWasabi\Helpers\PasswordConsole.cs:line 17
   at WalletWasabi.Gui.CommandLine.Daemon.RunAsync(String walletName, Boolean mixAll, Boolean keepMixAlive) in C:\Users\RESEAU\Desktop\WalletWasabi\WalletWasabi.Gui\CommandLine\Daemon.cs:line 55
   at WalletWasabi.Gui.CommandLine.MixerCommand.InvokeAsync(IEnumerable`1 args) in C:\Users\RESEAU\Desktop\WalletWasabi\WalletWasabi.Gui\CommandLine\MixerCommand.cs:line 47

And running ./wassabee mix --wallet:MyWalletName on v1.1.10.3 I get only this:

Password: 2020-03-14 19:59:40 INFO      Daemon (131)    Daemon stopped.
commands: There was a problem interpreting the command, please review it.

[nopara73]

• What OS?
• Could you try a simple hello world application with just Console.ReadKey(true)?
• And also Console.ReadKey(false)?

IMO we could catch the exception for Console.ReadKey(true) and do Console.ReadKey(false) as a fallback. It isn't elegant to display the password while the user is writing, but it's also not the end of the world for this edge case.

[nopara73]

Another solution could be using Console.In. https://stackoverflow.com/questions/46901071/readkey-not-working-in-net-core/46952718

[yahiheb]

What OS?

Windows 7

The above commands worked when I used the windows cmd but didn't work using Git Bash.
With Git Bash it doesn't prompt you to enter the password.

Btw the command that worked for v1.1.10.3 is wassabeed mix --wallet:MyWalletName not ./wassabee mix --wallet:MyWalletName

[yahiheb]

Notes:
I have a wallet without a password, hitting enter without providing a password results in Wrong password. 3 attempts left. so I couldn't pass this step.

I have a wallet named Testnet Wallet which contains a space, trying to use daemon with it results in The selected wallet does not exist, did you delete it?

[nopara73]

Please try out console readkey and console.in from a hello world program as I suggested.

[yahiheb]

Please try out console readkey and console.in from a hello world program as I suggested.

Tried that but what should I do or what should I expect?
There is no Console.In.ReadKey().

[nopara73]

I expect Console.ReadKey(true) to throw an exception and Console.ReadKey(false) doesn't.

Are you sure you don't get exception for Console.ReadKey(true)? That would be quite problematic news as you get it in Wasabi.

[nopara73]

Nevermind. Whatever you'd find, the solution wouldn't change: https://github.com/zkSNACKs/WalletWasabi/pull/3268

[yahiheb]

Are you sure you don't get exception for Console.ReadKey(true)? That would be quite problematic news as you get it in Wasabi.

Yes I got a InvalidOperationException.