Walletwasabi: Final tests before release 1.1.10

[molnard]

This is a guide on what to check in Wasabi according to the Release notes.

Do not narrow down the test cases only for this guide, the more tests the better the result.

If you find and issue do not write it here, open a new issue one-by-one here.

Test vector table moved here:
https://github.com/zkSNACKs/WalletWasabi/issues/2721#issuecomment-562503227

[Rmartin1104]

Hardware kata tests in Win 10 :
Trezor T done
Trezor one done
Coldcard done
Ledger Nano S

[Rmartin1104]

Win:

PR 2 done
PR 3 done
PR 4 done
PR 7 done
PR 9 done
PR 13 done
PR 14 done
PR 16 done

[davterra]

Since this thread is about a number of tests, should issues arising from any of these tests be reported here, or opened independently as a new issue, or both?

[MaxHillebrand]

Did the unit test both on Debian 10 and Fedora 30, both times

Test Run Successful.
Total tests: 231
     Passed: 231

[davterra]

I am not able to change the anonymity levels in my settings and have the changes be persistent from one run to another. They appear to "stick" when changed, but upon restart revert to the original 2/21/50 setting.
Using Ubuntu 19.04 + i3
Also: All unit tests successful with ubuntu 19.04

[MaxHillebrand]

Tested on Qubes 4 with both Debian 10 and Fedora 30 VMs, the results were the same on both OSs. Also used the i3 window manager.

1. Works
2. Works
3. Works
4. Works. Didn't test for Windows, but the old package on Debian got removed when installing RC1 package
5. Works. Did not test double spends or reorgs, but did many successful transactions and CoinJoins.
6. Works
7. Works
8. At one time, on the package RC1 I cannot copy and paste [i3 bug of #2026]. However when I checkout RC1 tag and compile from source, I can copy and paste. [both on Debian and Fedora]. Oddly, after rebooting RC1 package, it worked flawlessly, so I can no longer reproduce the bug...
9. Works
10. Works
11. Works, but did not complete IBD.
12. Works
13. Works
14. TODO
15. Cannot test [i3wm]
16. Memory usage is definitely heavy, and it is a lot less with #2720
17. Works
18. Works [both new wallets and rescanning old wallets.
19. Works

Bugs I noticed

• I cannot click with the mouse in the text box to change the cursor, this is thought to be fixed according to #2337, but it is not fixed.

Spent issue

I did several rounds of mixing, in one VM with the headless daemon, in the other with the GUI, disconnected internet spontaneously on both, dequeued coins, force quit wasabi, and other similar stress tests. NO SPENT ISSUE!!!

[ghost]

Did the unit test on macOS Catalina v10.15.1 three times to be sure, everything seems ok:

```Test Run Successful.
Total tests: 231
Passed: 231
Total time: 1.9796 Minutes

[ghost]

The following tests have been done on the same OS written above: macOS Catalina v10.15.1 (in progress):

2 Works without any issue, see above
9 Possible bug found
10 Possible bug found
13 Possible bug found
16 Works without any issue, tried different times

Bugs I noticed related to tests

• _Related to 9_
  In the "About" tab the copy function does not work on any links (both via keyboard and right click).

• _Related to 10_
  Tried with the "Open Wallets Folder" browse file dialog. If the Finder is already opened before using the function, when I close the file dialog without selecting any file, I am redirect to the Finder app. I think that the correct behaviour should be to stay in Wasabi when closing the file browsing window.

• _Related to 13_
  I generated a new receive address and then saw the related QR Code. Clicking on it with the right click I chose the "Save QR Code" option. A file manager windows appeared and I chose to save the image on the Desktop. However, no image has been saved on the Desktop and now the "Save QR Code" option is greyed out for all the new generated addresses, not only the initial one.

Out of test scope bugs I found

• Within the "Send" tab in the Address textbox I noticed that the following characters are represented with a sort of a rectangle character that I am not able to paste here: £, ì, è, é, ò, ç, à, °, ù, §, €
  That's not strictly an issue as these characters should be invalid and they are instead correctly represented in the Label textbox below.

• If a PIN is not set and I use the Lock screen functionality, I can not unlock it. Not sure if there are any gestures as per #1614 and #1681 but I am trying everything with mouse and keyboard and nothing happens. Also in the menu, a function like "Unlock Screen" is not available (if it was ever implemented in case a PIN is not set).

• Again related to the Lock Screen functionality, I noticed possible security issues.
  First, you could bypass the insert of the correct PIN by changing to "false" the "LockScreenActive" value in the UiConfig.json file. Also, i see in the GUI that there is this message: "If you forget the PIN, clear it by manually deleting the hashed PIN from your UIConfig file". So what's the meaning of a PIN if anyone with access to the computer can clear it or disable the function? Physical shared computer / unguarded computer is the scenario that the PIN is trying to prevent here to me but it seems not effective as it is.

• On first opening of the Wasabi Wallet app from /Applications, after confirming the OS Security Message, the app tries to start but actually there is only the "bouncing" animation on the OS dock while the app is not opening. You have to force quit it and then reopen it again, then it works.

[yahiheb]

Lurking Wife Mode does not cover important infos during the detailed view of a UTXO (we should hide labels that are marked with red

@RiccardoMasutti #2234

[davterra]

The following tests have been done on the same OS written above: macOS Catalina v10.15.1 (in progress):

2 Works without any issue, see above
9 Possible bug found
10 Possible bug found
13 Possible bug found
16 Works without any issue, tried different times

Bugs I noticed

* _Related to 9_
  In the "About" tab the copy function does not work on any links (both via keyboard and right click).

* _Related to 10_
  Tried with the "Open Wallets Folder" browse file dialog. If the Finder is already opened before using the function, when I close the file dialog without selecting any file, I am redirect to the Finder app. I think that the correct behaviour should be to stay in Wasabi when closing the file browsing window.

* _Related to 13_
  I generated a new receive address and then saw the related QR Code. Clicking on it with the right click I chose the "Save QR Code" option. A file manager windows appeared and I chose to save the image on the Desktop. However, no image has been saved on the Desktop and now the "Save QR Code" option is greyed out for all the new generated addresses, not only the initial one.

* _I think not related to any of the tests above_
  Within the "Send" tab in the Address textbox I noticed that the following characters are represented with a sort of a rectangle character that I am not able to paste here: £, ì, è, é, ò, ç, à, °, ù, §, €
  That's not strictly an issue as these characters should be invalid and they are instead correctly represented in the Label textbox below.

I can reproduce "Related to 9" using ubuntu 19.04, but I cannot reproduce
"Related to" items 10, or 13. Those work fine for me.

[yahiheb]

Bugs Related to 7 (Play with Select and Select all. Change Anonset target and check functionality.)

@RiccardoMasutti
https://github.com/zkSNACKs/WalletWasabi/pull/2509#pullrequestreview-316019967

[davterra]

[ WORK IN PROGRESS ]

Other Bugs

* When I click `Open`>`Tor Log File`, No file / folder is opened (tried both on Debian and TAILS)

I am able to open 'Open > Tor Log File' using Ubuntu 19.04

[kravens]

OS: Windows 10 (10.0.18362 Build 18362)
1: Works
2: All Passed

dotnet test --filter UnitTests
...
Test Run Successful.
Total tests: 231
Passed: 231
Total time: 1,8180 Minutes

3: Works
4: Works, old version 1.1.9 did not after running the self-build from source code.
5: No issues, rescanned switching to Testnet/Mainnet balance is correct.
6: Works, putting dust limit very high (>0.1BTC) makes no sense... maybe a warning notification could be given if it is set unreasonably high (by the user). "Coins below x.xxxBTC not displayed!"
7: Works perfectly here!
8: Also PSBT with Coldcard (no passphrase) worked perfectly, no bugs encountered so far.
9: Ctrl+C and rightclick copy work fine in coin details
11: Looks fine.
13: Works and is the correct address when scanned.
14: Works fine
15: Tested display receive address on NanoS, works perfectly!
16: Wasabi quits with x-button, menu exit and Alt+F4
17: Never using more than 350MB, typically around 200MB of RAM and 3% GPU.
*update: Memory usage went to 500+MB after a day of coinjoin action.

18: Website is very pretty, intuitive and functional!
19: Testnet wallet reprocessed all block filters and downloaded blocks. It does have interruptions in testnet nodes that it downloads blocks from, is the handshake OK for testnet? Or could Wasabi be rude and get peer banned?

2019-12-05 23:10:00 INFO WalletService (463) Disconnected node: ::ffff:34.240.103.46. Block downloaded: 00000000000049c1ac7f320ae0ef64ddf2920e4d2ff6b34e6fde8d663ed70519.
2019-12-05 23:10:10 INFO WalletService (463) Disconnected node: ::ffff:202.185.204.144. Block downloaded: 0000000000006eb0bfb42fc37206bbeffcc722a3160a7b7d49301be190756895.
2019-12-05 23:10:17 INFO WalletService (463) Disconnected node: fd87:d87e:eb43:e4b1:5759:b8b9:1358:72d. Block downloaded: 00000000006873015907be634e32b7d5b28e27a3c7b159b1b3efa0ad3b3537a4.
2019-12-05 23:10:22 INFO WalletService (463) Disconnected node: ::ffff:139.162.76.144. Block downloaded: 0000000000fc7c74abb00c03263c5e973728428bc63be61e2dfac7e06f631321.
2019-12-05 23:10:29 INFO WalletService (463) Disconnected node: ::ffff:69.59.18.23. Block downloaded: 000000000002417686d621a88cb2a3c4ce07ffe10cb4aa0881a709a3d0f5d271.
2019-12-05 23:11:03 INFO WalletService (471) Disconnected node: ::ffff:52.221.229.70, because block download took too long.
2019-12-05 23:11:05 INFO WalletService (463) Disconnected node: fd87:d87e:eb43:6a8b:d278:3f7a:f892:8f80. Block downloaded: 000000000000411a1699e751b69aef95117d6336a004b19ddc7b6023176ac964.
2019-12-05 23:11:08 INFO WalletService (463) Disconnected node: ::ffff:34.77.214.163. Block downloaded: 000000000000090577dedefc07ee374c4e989320cdce245161c21e75316b4621.

*on mainnet I use my own bitcoin node, also works fine.
20: My older wallet converted fine, no missing info or utxo.

[Rmartin1104]

| PR | Description | Win | Mac | Lin
| ------------- |:-------------:|---:|---:|---:|
| 1 |Transactions test: create transactions, send/receive, create PSBT, broadcast it.|✅ | | |
| 2 |Run the unit tests. dotnet test --filter UnitTests|✅ | | |
| 3 |Manual fee box tests: enable/disable manual fee, set manual fee, check, set fee with slider check. Restart Wasabi, check default fee.|✅ | | |
| 4 |Msi installer test on windows. Install 1.1.9.1-2 Wasabi. Install new one, check of the previous version removed.|✅ | | |
| 5 |Coin tests. Try to manipulate coins, create transactions, double spends, RBF, rescan wallet check balance is correct.| | | |
| 6 |Play with the dust limit and check functionality.| | | |
| 7 |Play with Select and Select all. Change Anonset target and check functionality.|✅ | | |
| 8 |Check PSBT workflow with ColdCard. With and without a passphrase.| | | |
| 9 |Check Copy/Paste with buttons/mouse/etc on every OS.|✅ | | |
| 10 |Check the browse file dialog on macOS and Linux.| | | |
| 11 |Check status bar functionality. Delete blocks, filters, Tor, Backend status.|✅ | | |
| 12 |Bitcoin core integration tests, download blockchain, data folder setup, download blocks, check status indicator|✅ | | |
| 13 |Save the image of QR code.|✅ | | |
| 14 |Test notifications.|✅ | | |
| 15 |All hardware wallet katas and tests.|✅ | | |
| 16 |Quit Wasabi from the menu or with buttons, especially on macOS.|✅ | | |
| 17 |Use the UI and check memory usage if increasing endlessly - memory leak.| | | |
| 18 |Check the new website, click everywhere, on mobile, in onion browser.|✅ | | |
| 19 |Set BlockchainState.Height to zero in wallet file and rescan the filters.|✅ | | |
| 20 |Compatibility check. Use old wallet file and check if it is converted and works the same as to before.|✅ | | |

[molnard]

@davterra @SimoneBovi @RiccardoMasutti @kravens thank you for your time to take part in the game!

Please open new issues one-by-one. Few important things:

• Use the issues template!
• Check for duplicates before submitting them!
• Add guide on how to reproduce the bug!

Keep it up!

[RiccardoMasutti]

@davterra @SimoneBovi @RiccardoMasutti @kravens thank you for your time to take part in the game!

Please open new issues one-by-one. Few important things:

• Use the issues template!
• Check for duplicates before submitting them!
• Add guide on how to reproduce the bug!

Keep it up!

Done. I deleted by previous comment and added issues one-by-one (eliminating duplicates)

[molnard]

@SimoneBovi

Create issues, but check duplicates in advance!

• In the "About" tab the copy function
• Tried with the "Open Wallets Folder"
• I generated a new receive address and then saw the related QR Code
• Within the "Send" tab in the Address textbox I noticed
• If a PIN is not set and I use the Lock screen functionality
• On first opening of the Wasabi Wallet app from /Applications

Not an issue:

• Again related to the Lock Screen functionality, I noticed possible security issues.

[ghost]

@SimoneBovi

Create issues, but check duplicates in advance!

• In the "About" tab the copy function
• Tried with the "Open Wallets Folder"
• I generated a new receive address and then saw the related QR Code
• Within the "Send" tab in the Address textbox I noticed
• If a PIN is not set and I use the Lock screen functionality
• On first opening of the Wasabi Wallet app from /Applications

Not an issue:

• Again related to the Lock Screen functionality, I noticed possible security issues.

Sure, I will do that within today.

[molnard]

@kravens

Testnet wallet reprocessed all block filters and downloaded blocks. It does have interruptions in testnet nodes that it downloads blocks from, is the handshake OK for testnet? Or could Wasabi be rude and get peer banned?

It is OK. Wasabi downloads only one block from one node then disconnect it and gets the next block from another random node.

[yahiheb]

This was tested on Windows 7.

1 --> works
2 --> works
3 --> tested & reported bug
4 --> works
5 -->
6 --> works & reported bug
7 --> works but there is some known problems

9 --> works

11 --> works
12 --> works
13 --> works
14 --> works
15 -->
16 --> works
17 --> works --> After couple of minutes memory usage gets to 830mb, I don't know if that is bad or not
18 --> works
19 --> works
20 --> works --> the wallet used was last modified in 22.09.2019, I don't know if it's old enough

[molnard]

After 1.1.10 rc1 we gathered and solved the most important issues. Now we are a stage when I start the final tests again.

@Rmartin1104 please run the hardware test.

[molnard]

@MaxHillebrand @jmacato @bharmat @hgergoil @danwalmsley @nopara73 @yahiheb @lontivero
Please run another final test on the current master. If nothing critical I will release in 12 hours.

@MaxHillebrand please finalize the results of the contribution game, in this format: https://github.com/zkSNACKs/WalletWasabi/issues/2016

@SimoneBovi @davterra @RiccardoMasutti @kravens please check if your issues were solved, however, I closed the game so I cannot offer a bounty on this but I would appreciate it.

https://github.com/molnard/WalletWasabi/releases/tag/v1.1.10rc2

[Rmartin1104]

Hardware kata tests in Win 10 :
Trezor T done
Trezor one done
Coldcard done
Ledger Nano S done

[MaxHillebrand]

I ran the dotnet test --filters UnitTests again,

Debian 10

Test Run Successful.
Total tests: 231
     Passed: 231
 Total time: 2.3457 Minutes

Fedora 30

Test Run Successful.
Total tests: 231
     Passed: 231
 Total time: 3.2344 Minutes

[davterra]

Sorry to report that #2722 still exists for me. @SimoneBovi & @MaxHillebrand , you were both able to replicate recently. What say you now?

[molnard]

Test vectors according to PR-s
https://github.com/zkSNACKs/WalletWasabi/pulls?utf8=%E2%9C%93&q=is%3Apr+merged%3A%3E%3D2019-12-05+sort%3Aupdated-asc+

• User Fee testing: enter point, coma, invalid characters to UserFee, maximum, minimum https://github.com/zkSNACKs/WalletWasabi/pull/2743 https://github.com/zkSNACKs/WalletWasabi/pull/2747
• Enter wrong password, check user friendly message https://github.com/zkSNACKs/WalletWasabi/pull/2754
• Use open file dialog e.g. in import wallet. Try to open non existing file, Cancel, Ok, Quit https://github.com/zkSNACKs/WalletWasabi/pull/2755
  -Transaction broadcast button diabled if the input box is empty: https://github.com/zkSNACKs/WalletWasabi/pull/2752
• Check all legal docs related function. https://github.com/zkSNACKs/WalletWasabi/pull/2735
• Website, coinjoin link also in onion browser https://github.com/zkSNACKs/WalletWasabi/pull/2742 https://github.com/zkSNACKs/WalletWasabi/pull/2725 https://github.com/zkSNACKs/WalletWasabi/pull/2794
• Clear out the pwbox after dequeue https://github.com/zkSNACKs/WalletWasabi/pull/2792
• Screen lock PIN test: https://github.com/zkSNACKs/WalletWasabi/pull/2776 https://github.com/zkSNACKs/WalletWasabi/pull/2804 https://github.com/zkSNACKs/WalletWasabi/pull/2813
• Total reinstall of Wasabi from zero (delete wasabi data folder too) https://github.com/zkSNACKs/WalletWasabi/pull/2807
• Special characters to address box: https://github.com/zkSNACKs/WalletWasabi/pull/2806
• Copy history tx: https://github.com/zkSNACKs/WalletWasabi/pull/2740
• Website API test in onion borwser https://github.com/zkSNACKs/WalletWasabi/pull/2815
• Generate wallet test workflow https://github.com/zkSNACKs/WalletWasabi/pull/2812
• Receive Tab right click check context menu functions. Also on history and on coinlist https://github.com/zkSNACKs/WalletWasabi/pull/2816 https://github.com/zkSNACKs/WalletWasabi/pull/2814
• Send Tab Amount, Max button Select coins etc. https://github.com/zkSNACKs/WalletWasabi/pull/2842

[davterra]

I am able to send a testnet transaction, using manual fee selection, and inputting a fractional satoshi (1.3 sat) amount as the fee. Attempts to send using fractional satoshi amount < 1.0 as a fee generated error message

[bharmat]

Sorry to report that #2722 still exists for me. @SimoneBovi & @MaxHillebrand , you were both able to replicate recently. What say you now?

On OSX I can also repro:

1. start wasabi
2. open settings
3. change anonymity setting (change only one of them and do not click out of that box afterwards. Notcie the yellow warning message does not show up)
4. exit wasabi
5. restart wasabi
   In this case the anaonset is unchanged.

Another case:

1. start wasabi
2. open settings
3. change anonymity settings (all 3 of them)
4. Close settings tab
5. Reopen settings tab (values are changed.)
6. exit wasabi
7. restart wasabi
   In this case the anaonsets are unchanged.

If settings tab is not closed after changing the anonset, than at newt wallet opening the values are changed.

[molnard]

@davterra @bharmat I have fixed it https://github.com/zkSNACKs/WalletWasabi/pull/2851

[molnard]

I am able to send a testnet transaction, using manual fee selection, and inputting a fractional satoshi (1.3 sat) amount as the fee. Attempts to send using fractional satoshi amount < 1.0 as a fee generated error message

That works fine!

[davterra]

I am able to send a testnet transaction, using manual fee selection, and inputting a fractional satoshi (1.3 sat) amount as the fee. Attempts to send using fractional satoshi amount < 1.0 as a fee generated error message

That works fine!

It's actually possible to use fractional satoshi's as a fee in a real transaction? If so, I just learned something & apologize for wasting your time. I've obviously never tried it, and assumed that it was
not possible.

[lontivero]

It's actually possible to use fractional satoshi's as a fee in a real transaction? If so, I just learned something & apologize for wasting your time. I've obviously never tried it, and assumed that it was
not possible.

The minimum valid fee is 0 satoshis. You can pay any amount higher than that. Also, take into account that Wasabi doesn't let you specify the total fee to pay but the fee rate and this can be a fractional number, for example, if you pay 0.5 sats/vbyte and your transaction is 1000vbyte size then you are paying 500 stas. In summary, you are not paying a fraction of satoshi.

[davterra]

Sure, that makes sense. I guess, without really thinking about it, I assumed that a fractional satoshi fee rate could result in a total fee that was not an integer.

[kravens]

W10 UnitTests result of master branch:

Test Run Successful.
Total tests: 231
Passed: 231
Total time: 1,7564 Minutes

Also tested 1.1.10rc2 for #2835, now it no longer hangs and closes the window so the user must restart (and works properly again)!