Walletwasabi: [FINISHED] Contribution Game for Review of v1.1.10

[MaxHillebrand]

Problem

It has been two months since the last release, and we have achieved an enormous amount of work since then. There have been many * major * changes to Wasabi, and we will need to do exhaustive testing to ensure a stable released. We have decided to do a release candidate so that peers can test the software by installing the package and without needing to know how to compile Wasabi. Yet we have considered even further strategies to increase the number of reviewers of this next release.

Solution

There was already one contribution game to incentivize new and existing peers to get work done. And I would say it was very successful, with many new Wasabikas joining, including @yahiheb who has continued to support the project greatly.

Contribution Game for Review of v1.1.10

These are the procedures and guidelines for this contribution game:

• There are build binaries of the release candidate and release notes for all the operating systems for easy installation.
• There is a list with all the tests that should be run by every tester.
• Testers will only be qualified into the game if their bug reports are: with a detailed description, reproducible, and not a duplicate. If the review does not fulfill these criteria, then it is not eligible for a bounty reward. Feature requests are not eligible for the game.
• Every bug report and fixing pull request gets a rating on a scale from 1 - 2 - 3, the higher the value the higher the importance.
• At the end of the period, minimum three days, the total score is used as basis to distribute the total bounty. @molnard and @MaxHillebrand will tally up the score and find out the adequate bounty value in context of the entire efforts.
• The top three reviewers get a special bonus worth #1 0.08, #2 0.05, #3 0.02, this is to incentivize very thorough and in depth review.
• zkSNACKs graciously committed between 0.1 bitcoin and 0.5 bitcoin, depending on the quality and quantity of testers. If there are others who would like to contribute financially, please do!
• The bounties get paid out when v1.1.10 is officially released.
• zkSnacks employees are excluded from the bounty, since the review of the software is a regular task for them.

Of course this bounty is a gracious gift of the contributors [mainly zkSnacks ltd] and so the exact payout structure can be changed and adapted as the donors see fit, but there is a goal to have a fair and transparent process for this.

[molnard]

I created a milestone to indicate separate the new issues and the handled ones:
@MaxHillebrand you can query unhandled issues with this. If you checked and issues and valid please comment there something like: approved - 2 points and I will put it into the project board.

https://github.com/zkSNACKs/WalletWasabi/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+created%3A%3E%3D2019-12-05+no%3Amilestone+

[molnard]

Dear @SimoneBovi @davterra @RiccardoMasutti @varsnotwars @kravens

Thank you for your amazing work. With the help of that, we discovered some critical issues, mainly those are fixed recently. I expand the game time until tomorrow when I will release the new version hopefully. Until then I offer 6 points bonus and increase the total bounty to 0.3 BTC if you build wasabi master from source
https://github.com/zkSNACKs/WalletWasabi#build-from-source-code

Check the test vectors and additionally check the fixes of these PR-s:
https://github.com/zkSNACKs/WalletWasabi/issues/2764
https://github.com/zkSNACKs/WalletWasabi/issues/2800
https://github.com/zkSNACKs/WalletWasabi/issues/2765
https://github.com/zkSNACKs/WalletWasabi/issues/2771
https://github.com/zkSNACKs/WalletWasabi/issues/2738
https://github.com/zkSNACKs/WalletWasabi/pull/2740
https://github.com/zkSNACKs/WalletWasabi/issues/2722
https://github.com/zkSNACKs/WalletWasabi/issues/2791

Keep it up! Please post your results here in this thread.

[ghost]

[WORK IN PROGRESS]

Thank you very much for this great opportunity!

Here are the results of PR-s fixes check (macOS Catalina 10.15.1):

• #2764: @molnard it would be great to have an updated .dmg to test this or a guide on how to build dmg in a reliable way from Visual Studio project
• #2800: works for me
• #2765: that's awesome now, great!
• #2771: works for me
• #2738 & #2740: work for me
• #2722: the anon levels are persistent. UPDATE: I can confirm the results from @davterra below, procedure 1 makes the changes not persistent, procedure 2 is ok instead. So likely the issue appears when the Settings tab is closed.
• #2791: password textbox is now empty

[davterra]

Here are my test results, with master built from source, all using Ubuntu 19.04 (without i3wm)
as a virtualbox VM

2764

Cannot replicate. Works fine

2800

Cannot replicate. Works fine

2765

Looks much better. Fixed

2771

No problems/works fine for me

2738/2740

Can no longer replicate. Seems fixed.

2722

This issue still exists for me. There are
two procedures that I've been testing.
Procedure # 1 does NOT result in updated
anonymity params, but Procedure # 2 DOES
result in updated anonymity params.

Procedure #1:

1) start wasabi
2) open settings
3) change anonymity settings
4) close settings tab
5) reopen settings tab to verify new params still there.
6) close settings tab
7) exit wasabi
8) restart wasabi
9) open settings tab. When I follow this procedure, my A.S. settings
are not as they were when I exited wasabi. They reflect prior settings.

Procedure #2:
1) start wasabi
2) open settings
3) change A.S. params
4) LEAVE SETTINGS TAB OPEN & exit wasabi
5) restart wasabi
6) open settings tab. When I follow this procedure, my A.S. settings are as
they were when I exited wasabi - Updated and correct.

2791

Works fine for me. Fixed

[RiccardoMasutti]

Keep it up! Please post your results here in this thread.

Wasabi build from source on Debian 10:

• #2764: Never had this issue
• #2800: OK
• #2765 / #2763: OK
• #2738: OK
• #2740: OK
• #2722: OK
• #2791: OK

[molnard]

@MaxHillebrand Please close the game, no more issues from now.

Use this to summarize the results: https://github.com/zkSNACKs/WalletWasabi/projects/6

Wasabi employees do not count as we decided earlier.

[MaxHillebrand]

After consideration of the point distribution and general discussion with @molnard about the quality and quantity of reviewers, there is the following percentage allocation of the bounty. zkSNACKs has commited to a total bounty of 0.3 bitcoin, which will be distributed as followed:

@RiccardoMasutti 45 % = 0.135 btc
@SimoneBovi 24 % = 0.072 btc
@davterra 24 % = 0.072 btc
@varsnotwars 4 % = 0.012 btc
@mikispag 2 % = 0.006 btc
@kravens 1 % = 0.003 btc

Thank you very much to all the reviewers and testers!! Thanks to you we could ensure a stable and smooth release.

To the reviewers, if you want to claim the bounty, please send me your Bitcoin address on DM [mail, telegram, signal, slack, twitter, you'll figure it out] so that I can forward you the sats. For your own privacy sake, please don't post your address publicly on GitHub, and consider encrypting it to my PGP key. E900 5F66 A86B B816 BD7D 967E BEDC D95C 42AC 3C57