Walletwasabi: Make QR code Capital letter Bech32

Created on 13 Nov 2019  路  6Comments  路  Source: zkSNACKs/WalletWasabi

Problem

Currently the QR code is in lower case letters, this is inefficient.

Solution

According to this research by @bitcoinops, bech32 was designed so that the QR code is very efficient, if the address is encoded in capital letters.

featurenhancement

Most helpful comment

@lontivero I can confirm that QRCoder generates the proper and smaller QR code for uppercase alphanumerics.

All 6 comments

This is currently blocked by QrCodeNet not detecting proper encoding modes.. I tried encoding uppercase addresses on our QrCodeNet and it doesnt properly detect the correct encoding, hence not shrinking the QR code.

It doesn't detect it because I think we removed that part.

@lontivero i see.. was it too buggy with the character encoding detection? because other QR encoders online does shrink the matrix

@jmacato take a look at this commit: 1e7278469 where I removed all the encodings to simplify the QrCodeNet code. The only encoding used by wasabi is the EightBitByteEncoder but I think it could be good to change it by the removed AlphanumericEncoder. Anyway, that encoder does not make any difference regarding lower-case characters and upper-case characters neither.

@lontivero I agree, though we should also consider to replace QrCodeNet with a newer library (https://github.com/codebude/QRCoder). I can strip that one down and use it for this. This feature is also useful because the larger the qr code blocks are, the better they'd be detected at farther distance.

@lontivero I can confirm that QRCoder generates the proper and smaller QR code for uppercase alphanumerics.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MaxHillebrand picture MaxHillebrand  路  3Comments

molnard picture molnard  路  3Comments

yahiheb picture yahiheb  路  3Comments

RiccardoMasutti picture RiccardoMasutti  路  3Comments

nopara73 picture nopara73  路  3Comments