Walletwasabi: Question about throwing exceptions

[yahiheb]

From a UX point of view wouldn't be better to simply display the message without the type of the exception. I don't think that most of the users understand or care about the type of the exception, they simply need to know what happend or what they need to do next.
E.g. we simply need the message here throw new SecurityException("Invalid password.", ex);.

[lontivero]

I agree with you, @yahiheb. If the exception contains a message then we should display that. This same thing was already discussed before and @nopara73 said that he likes the messages with the exception (https://github.com/zkSNACKs/WalletWasabi/issues/5750) however, I changed that on the Send tab translating those well-known (and expected) exceptions by more user-friendly messages and the PR was accepted.

[nopara73]

As I remember we discussed this on the dev meeting. If an exception is shown to the user, then it means we didn't translate that exception properly to the user in the appropriate context. Also that it makes more sense to work on exception translation after our notifications are ready.

[MaxHillebrand]

In light of the new notifications, I'll reopen the issue as this should be fixed in the new UI

[nopara73]

Fixed.

[yahiheb]

This is not fixed.

[nopara73]

Correct.