https://twitter.com/_prestwich/status/1304986329604710401?s=20
Basically, since gas costs change all the time, we can't rely on the estimates that a particular version of Vyper uses. So, we should just get rid of this "feature"
NOTE: we'll still keep an upper bound on gas usage, for use with optimizations and to prevent gas attacks
fubuloubu
All 5 comments
I'd like to take a swing at this...
bitcoinbrisbane
on 28 Nov 2020
Should be as simple as removing this guy? https://github.com/vyperlang/vyper/blob/master/vyper/compiler/output.py#L56
bitcoinbrisbane
on 29 Nov 2020
@bitcoinbrisbane it should be that easy, yes! But if you could also try to remove that functionality from the rest of the codebase and the test suite, that'd seal the deal!
fubuloubu
on 29 Nov 2020
@bitcoinbrisbane it should be that easy, yes! But if you could also try to remove that functionality from the rest of the codebase and the test suite, that'd seal the deal!
On it
bitcoinbrisbane
on 29 Nov 2020
43 tests break after removing it, taking a bit of time to refactor those tests.
bitcoinbrisbane
on 5 Dec 2020
Related issues
jacqueswww
路
4Comments
pipermerriam
路
3Comments
denis-bogdanas
路
3Comments
jacqueswww
路
3Comments
vici0
路
3Comments
Most helpful comment
43 tests break after removing it, taking a bit of time to refactor those tests.