Vuetify: [Bug Report] Broken logic in 2.3.5 (Cannot read property 'hasAttribute' of undefined)

Created on 21 Jul 2020  路  13Comments  路  Source: vuetifyjs/vuetify

Environment

Vuetify Version: 2.3.5
Vue Version: 2.6.11
Browsers: Chrome 81.0.4044.138
OS: Mac OS 10.13.0

Steps to reproduce

It appears after commit "use xs breakpoint on inital render when hydrating": (https://github.com/vuetifyjs/vuetify/pull/11842/files)
This commit has broken all dialogs in vuetify-dialog (npm module), because sometimes vue component doesn't have $el in global hook beforeMount

For example , when component was mounted with vm.$mount() function and connect to DOM later
image

Expected Behavior

check is this.$el exists

Actual Behavior

now always error "Cannot read property 'hasAttribute' of undefined"

Reproduction Link

https://codesandbox.io/s/vuetify-2-dialog-example-kgehb

Framework bug regression

Most helpful comment

Looking to get this out today.

All 13 comments

im also having this issue when running my jest tests :/

same here.. same error on all components in storybook

image

The same. Several tests are broken because of this.

I can confirm that yarn upgrade [email protected] fixes the issue.

when will this be relased? :)

Also confirming that version 2.3.5 breaks my tests.

ere.. same error on all components in storybook

I also had to revert to 2.3.4 on my storybook project

Will we get a hotfix release or is this just going out with next week's patch?

Looking to get this out today.

I am running into the Problem that our Teamcity pipeline is throwing the mentioned error for all tests dealing with vuetify. When I run my jest tests locally everything is fine. Tested it with version 2.2.15, 2.3.4 and 2.3.5 => always the same result

2.3.4 , 2.3.5 the same problem.

Only a problem for me on 2.3.5, 2.3.4 is fine

Apologize for the delay, running into CI issues trying to get the patch out. This fix will be released as soon as that is resolved.

We kindly ask users to not comment on closed/resolved issues. If you believe that this issue has not been correctly resolved, please create a new issue showing the regression or reach out to us in our Discord community.

Thank you for your contribution and interest in improving Vuetify.

Was this page helpful?
0 / 5 - 0 ratings