Vuetify: [Feature Request] Support for faSvg in 2.0

Created on 25 Jul 2019  路  4Comments  路  Source: vuetifyjs/vuetify

Problem to solve

Allows the use of Fontawesome SVG icons

Proposed solution

This was implemented in 1.5 but was removed in 2.0 not sure why, maybe we could copy over the code from 1.5 over to 2.0? I could help with a PR if you approve.

VIcon elite sponsor has PR regression

Most helpful comment

@garlian Yea that's why I opened this issue, I have a fork updated with the necessary code to make faSvg work but I am waiting on Vuetify's team approval of this issue as they might have removed faSvg support for a reason.

All 4 comments

Documentation states that "faSvg" is an option:
https://vuetifyjs.com/en/customization/icons#install-font-awesome-svg-icons

But VuetifyIconOptions is missing "faSvg", so the documented usage is not possbile right now :-(

For example see here:
https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/types/services/icons.d.ts#L13
and here
https://github.com/vuetifyjs/vuetify/tree/master/packages/vuetify/src/services/icons/presets

@garlian Yea that's why I opened this issue, I have a fork updated with the necessary code to make faSvg work but I am waiting on Vuetify's team approval of this issue as they might have removed faSvg support for a reason.

Yeah im pretty sure this is a valid regression, so feel free to PR

blame: #6464, bf709a1f5c47214d2cd9eff73b83bb4438793236

The original feature #4910 was done after the bf709a1f5c47214d2cd9eff73b83bb4438793236 branch started.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dschreij picture dschreij  路  3Comments

dohomi picture dohomi  路  3Comments

efootstep picture efootstep  路  3Comments

smousa picture smousa  路  3Comments

KuroThing picture KuroThing  路  3Comments