Vuetify: 1.4.2
Last working version: 1.3.7
Vue: 2.5.22
Browsers: Chrome 71.0.3578.98
OS: Windows 10
Create a ExpansionPainel with lazy ExpansionPainelContents.
The opening animation to work initially, even with lazy content.
This used to work with v1.3.7, like in this codepen .
The opening animation do not work.
@oliveiracdz In which version it broke?
@sh7dm, version 1.3.10.
Maybe something related with this commit d0ffc88a75a2179bc5fbdb5578405863acfb47eb?
@oliveiracdz It works in both directions in v1.3.7 https://codepen.io/sh7dm/pen/XOrZad
Only on open: v1.3.8 / v1.3.9 https://codepen.io/sh7dm/pen/ErYQwg
Doesn't work at all 馃が: v1.3.10 https://codepen.io/sh7dm/pen/pGzadz
Looks like close anim was removed in 97053db
These commits between v1.3.9 and v1.3.10 are related to VExpansionPanel
: ebc5aaf cb605ac a039846
Hmm... it only doesn't work for first time, then anim works good. It's very strange
@oliveiracdz you were right! when I removed !!
it works good. Looks like this was for Boolean()
conversion
After I do this:
toggle (active: boolean) {
- if (active) this.isBooted = true
+ if (active !== undefined && active) this.isBooted = true
this.isActive = active
}
and this:
register (content: VExpansionPanelContentInstance) {
const i = this.items.push(content) - 1
this.value !== null && this.updateFromValue(this.value)
- content.toggle(!!this.open[i])
+ content.toggle(this.open[i])
},
it works
@oliveiracdz Thanks
@sh7dm, this fix breaks #5703 again. =/
Now the lazy content renders before open the expansion, like in this
codepen with v1.4.5.
:boom: It's very difficult to fix. I think we need @johnleider's help!
I have a fix for this going up
Thanks!
But I think that d3937e05228474844d764c55ef6c23ca0a58dfb1 broke this another https://github.com/vuetifyjs/vuetify/issues/4483 now.
This change broke my expansion-list with a component containing dynamic chart. Code Example:
https://codesandbox.io/s/98wo5r0664
Most helpful comment
I have a fix for this going up