Vuepress: 404 page does not support i18n

Created on 27 Oct 2019  路  4Comments  路  Source: vuejs/vuepress




  • [x] I confirm that this is an issue rather than a question.




Bug report

I just find this on stackoverflow, and test it on the official website

Steps to reproduce

Try to visit vuepress.vuejs.org/zh/test

What is expected?

A 404 page with Chinese and

html <html lang="zh-CN" >

What is actually happening?

html <html lang="en-US" >

Other relevant information

  • Output of npx vuepress info in my VuePress project:
easy contribution welcome medium good first issue theme feature request
Source
picture ludanxer
👍1

Most helpful comment

Hello @ludanxer, this seems like a good fist issue for me on this project !
I will submit a PR for it later this week ;)

picture dzetah on 6 Nov 2019
❤1 👍1

All 4 comments

Hello @ludanxer, this seems like a good fist issue for me on this project !
I will submit a PR for it later this week ;)

dzetah picture dzetah on 6 Nov 2019
❤1 👍1

Hi @dzetah
Did you submit a PR?

ThaddeusJiang picture ThaddeusJiang on 1 Apr 2020

Yes, he kindly did #2004 , I believe it's not ready because

Currently, it will show the default messages first, and change to the locale messages.

It's not so perfect 馃

https://deploy-preview-2004--vuepress.netlify.com/zh/guide/aaa

demo-locale

ludanxer picture ludanxer on 1 Apr 2020
👍1

Hi @dzetah

Did you submit a PR?

Yes I did but I have to fix it because there鈥檚 a still a small bug. I had no time at all to do that recently, I鈥檒l try to do it this week.

dzetah picture dzetah on 1 Apr 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ynnelson picture ynnelson  路  3Comments
genedronek picture genedronek  路  3Comments
ynnelson picture ynnelson  路  3Comments
shaodahong picture shaodahong  路  3Comments
cfjedimaster picture cfjedimaster  路  3Comments