Vuepress: "Last updated" feature is coupled to Git

Created on 4 May 2018  路  6Comments  路  Source: vuejs/vuepress

The "Last updated" feature implemented in #282 is tightly coupled to Git.

  • It assumes Git is installed.

  • It assumes the project uses Git. The process will crash if the directory is not a Git repository. This is a serious issue if you're just starting out with documentation in a new directory or if you (have to) use something other than Git.

_Also see https://github.com/vuejs/vuepress/pull/282#issuecomment-386590298._

All 6 comments

Thanks for reporting for that.

And I also concerned for that. since I believed that most of users use git so I let it go, but it's truly a potential problem, I will disable it by default.

BTW, we will make this feature as a plugin in the future.

BTW, You have been saying this question so early 馃槄 we even haven't released it yet. awesome !

Fixed at: 4921f99

@ulivz What about using mtime from fs.stat() by default (because its always available) and make using the Git last modified timestamp an option?

Fixed at 272df57421d20907b5a1edecabcaad649641e791 (#338)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ederchrono picture ederchrono  路  3Comments

shaodahong picture shaodahong  路  3Comments

lileiseven picture lileiseven  路  3Comments

AMontagu picture AMontagu  路  3Comments

lesliecdubs picture lesliecdubs  路  3Comments