Vue2leaflet: support for typescript
does vue2leaflet support typescript, i don't seem to find any topic about it?
walidsebai
All 16 comments
There is no defined types for Vue2Leaflet at the moment, also the types for leaflet are not official too ( but do exist )
We would welcome a PR tho!
DonNicoJs
on 24 Sep 2018
heres most of the types (they require you install @types/leaflet)
Link to blob with types
I am trying to make a PR but its not happy right now
HIMISOCOOL
on 2 Oct 2018
@HIMISOCOOL Thank you very much! Please take a look at the current master after the refactor it should be easy to define types starting from the mixin :)
DonNicoJs
on 3 Oct 2018
wanted to help but it seem he has done everything
walidsebai
on 15 Oct 2018
wanted to help but it seem he has done everything
its not 100% right now, I only put proper types to the components I am using, the rest are just extending Vue. If you have time you can make types for all the other mixins and post the updated version here
HIMISOCOOL
on 15 Oct 2018
ok, i will get on it tomorrow if i can.
walidsebai
on 16 Oct 2018
@walidsebai Are you still on this? Would love to see this aswell.
kevcodez
on 21 Oct 2018
yeah but i'm busy at the moment i will take care of it in 2 week
walidsebai
on 21 Oct 2018
@lordfuoco I started a branch and then made most of the changes,
https://github.com/HIMISOCOOL/Vue2Leaflet/commit/b1f770a
but for some reason it doesn't want to show up as a branch change or let me make any PR's, what am I doing wrong DX
HIMISOCOOL
on 22 Oct 2018
@walidsebai @kevcodez check out my original comment, I've edited it with about ~80% of the types filled now
HIMISOCOOL
on 22 Oct 2018
If you want to contribute you need to fork the repo and do a branch there and then create a PR :)
DonNicoJs
on 22 Oct 2018
turns out there was a github outage, just my luck.
anyway #258 is up and ready to review.
@walidsebai has had a quick look, am I missing anything from your types?
HIMISOCOOL
on 22 Oct 2018
@HIMISOCOOL no i don't thinks so other than more precise type, but we can do that as an enhancement.
walidsebai
on 22 Oct 2018
@walidsebai yeah I agree, it would take using them at runtime to figure out what is more appropriate than the many any's for a start
HIMISOCOOL
on 22 Oct 2018
fixed by #258
DonNicoJs
on 27 Oct 2018
Closing this :)
DonNicoJs
on 28 Oct 2018
Related issues
mits87
路
3Comments
rSammy
路
3Comments
tiltec
路
4Comments
digEmAll
路
4Comments
udos
路
4Comments
Most helpful comment
heres most of the types (they require you install @types/leaflet)
Link to blob with types
I am trying to make a PR but its not happy right now