Vue-storefront: One-word component names

Created on 16 Aug 2018  路  7Comments  路  Source: DivanteLtd/vue-storefront

I've noticed that there are components named with only one word, this is strongly discourage by Vue style guide and W3C specifications because it could encounter conflicts in future HTML5 tags.

Maybe we should think about a refactoring of these components name? 馃榿

Most helpful comment

@filrak please put it on Your checklist please :)

All 7 comments

My opinion is: it would be good to refactor it, but how about the backward compatibility? I think it would be much easier to develop new theme (and we're designing one from scratch now) to improve this and other architectureal/component things; rather than pushing incremental changes to the existing theme

WDYT?

Yes, I didn't know about the "new theme" project until one hour ago when I talked with @filrak . Now that I know what's on the plate I could say yes, it makes sense implemented it in the new one along with other code improvements 馃榿

OK, I think we'll close it for now?

Could be closed if you don't forget it 馃槤 馃槆

@filrak please put it on Your checklist please :)

Isn't better to keep it open and just add a proper label and milestone, rather than keeping it on some private "TO DO" list?

@Igloczek @lorenaramonda no problem

Was this page helpful?
0 / 5 - 0 ratings