Vue-material: Theme configuration broken after update to node-sass 4.8

Created on 22 Mar 2018  路  4Comments  路  Source: vuematerial/vue-material

Steps to reproduce

Updated from node-sass 4.5.3 to 4.8.3

Which browser?

Chrome, possibly others

What is expected?

No change in how themes are applied

What is actually happening?

Theme seems to be broken, specifically for background colors. Processed CSS with node-sass 4.8.3:

.md-button.md-theme-default.md-primary {
    color: #1a237e;
    color: var(--md-theme-default-primary-on-background, #1a237e);
}

Reverting to node-sass 4.5.3 corrects the problem.

bug

Most helpful comment

This is seems a node-sass or libsass issue.
whereas <= 4.7.2 got --md-theme-demo-light-primary: #448aff;,
>= 4.8.1 got --md-theme-demo-light-primary: $value;.
Changing the code to --md-theme-#{$name}-#{$type}: #{$value} fixes it.

It's better to downgrade your node-sass to ^4.7.2 for now. I'll report this issue to node-sass.

All 4 comments

This is seems a node-sass or libsass issue.
whereas <= 4.7.2 got --md-theme-demo-light-primary: #448aff;,
>= 4.8.1 got --md-theme-demo-light-primary: $value;.
Changing the code to --md-theme-#{$name}-#{$type}: #{$value} fixes it.

It's better to downgrade your node-sass to ^4.7.2 for now. I'll report this issue to node-sass.

Theming seems to be messed up even with node-sass: ^4.7.2 . I am running a brand new vue init vuematerial/webpack my-app and theme configuration doesn't seem to be working out of the box.

I am running Chrome on a Mac. Have also tried in Safari and Firefox.

BUT as you stated, the code change --md-theme-#{$name}-#{$type}: #{$value} does fix it with some linting issues.

I have the same issue

@jacksonrdlc node-sass: ^4.7.2 will update you back to 4.8.3, due to the caret operator. You can verify this with npx node-sass --version. I suggest you put "node-sass": "4.7.2" in your devDependencies until the fix is released.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dennisoost picture Dennisoost  路  16Comments

mattgrande picture mattgrande  路  25Comments

mygnu picture mygnu  路  40Comments

zapping picture zapping  路  24Comments

joshbotnet picture joshbotnet  路  46Comments