Vue-form-generator: fieldUpload not setting id attribute correctly

[jewbetcha]

Setting the id property in the schema for field type: "upload" results in markup that looks like:

<input id="getFieldID(schema)" 
     type="file"
     accept=".jpg,.jpeg,.png,.pdf" 
     required="required" class="form-control">

Comparing it to other core field files, it looks like in fieldUpload.vue the id prop is missing a colon, here.

Could be an easy/quick fix :)

[zoul0813]

@jewbetcha this PR should solve the problem - thanks.

[jewbetcha]

Thanks for the quick reply :)

@zoul0813 any estimate on a release date for this fix?

[zoul0813]

@jewbetcha you can use it now, just have npm reference the github repo's master branch instead of the npm package.

I believe @icebob will be releasing a new version to npmjs soon though.

In case you need it, here's how I reference VFG in my project:

  "devDependencies": {
    ... snipped
    "vue-form-generator": "git+https://github.com/zoul0813/vue-form-generator.git#develop",
  }

You would likely want to use git+https://github.com/vue-generators/vue-form-generator.git#master

Doing this, will allow you to keep up to date with the latest changes in the master branch and not wait for an npm package update ... I'd recommend only doing this during development, and to lock your production code to a specific npmjs release (or git tag/commit).

[jewbetcha]

Okay great. Thank you!

[jewbetcha]

I tried this, but ran into a multitude of babel/webpack errors. My project is on @babel 7.x and it looks like that and the associated plugins aren't cooperating with VFG from git. Hopefully @icebob will want to release soon :+1:

[icebob]

Released in v2.2.1

[jewbetcha]

@icebob awesome!