Vue-form-generator: Label not showing on image input

[pardmeister]

Hi

The label on my image input is not showing. My code is below:

{
    type: 'image',
    label: 'Identity document',
    hideInput: true,
    preview: true,
    model: 'id_document',
    required: true,
    styleClasses: 'col-sm-12'
}

Also, is there a more detailed tutorial in styling the forms?

Thanks
Pard

[lionel-bijaoui]

Can you provide a Fiddle ?
It will be easier to find a solution that way.
Thank you.

[pardmeister]

Will do, still reading up on creating fiddles.

[pardmeister]

Hi Lionel

Hope this works. By the way, this is a great component, thanks for the great work guys.

https://jsfiddle.net/kbg6gbyc/4/

[lionel-bijaoui]

I seem to be a feature.
I didn't knew this existed and I don't know why this is here.
@icebob can you explain this choice ? I don't see the need to prevent people from adding label to a field, even if it may be a bad idea.
We should remove that, since it add limitation for no clear reason.

---

FYI you can add the css of VFG with this link, no need to copy and paste it directly.
I updated your fiddle accordingly.
I you want, you can start with the official fiddle next time. I may be easier.

[pardmeister]

Yes, I noticed in this piece of code:

// Should field type have a label?
            fieldTypeHasLabel(field) {
                let relevantType = "";
                if (field.type === "input") {
                    relevantType = field.inputType;
                } else {
                    relevantType = field.type;
                }

                switch (relevantType) {
                case "button":
                case "image":
                case "submit":
                case "reset":
                    return false;
                default:
                    return true;
                }

Should have just posted that actually

[pardmeister]

Thanks for the assistance lionel

[lionel-bijaoui]

You are welcome 👍
Next time, yeah, start with that 😆

[pardmeister]

Hi

Has this been updated, or is there a valid reason why an image input should not have a label?

[lionel-bijaoui]

Sorry, I'm waiting on @icebob answer to fix this (or not if it is indeed a feature that make sense).

[icebob]

Hmm, I think it is a bug. Need to remove the image from the switch case.

[icebob]

@pardmeister Could you make a PR with fix?

[pardmeister]

@icebob Not a problem.

[pardmeister]

@icebob, @lionel-bijaoui Done, please review when you have time.

[icebob]

Thank you. Merged.