Vue-form-generator: Contribution guide

Created on 21 Mar 2017  路  4Comments  路  Source: vue-generators/vue-form-generator

I see vfg is more popular day-by-day. So maybe we need a contribution guide with base rules...
E.g.

  • don't commit dist files
  • don't throw errors in source codes
  • if modify a function, update tests, if add new function cover with new tests
  • ... etc

What do you think?

help wanted medium documentation

Most helpful comment

Yes, can we also agree on a coding style ? Because the sometime lack of curly braces caused many mistakes...

// don't do this, please !
if (true)
    console.log('hello');

// do this, please !
if (true) {
    console.log('hello');
}

All 4 comments

I personally agree with everything except dist giles. Even though I ddin't commit them so far, if they are commited you have the advantage of simply putting those in a fiddle and testing out stuff like I did with the string validators.

Rightful, but if there are two PRs with dist files, will be problem with merging.

Hi there guys,

yes, a contribution guide is always appreciated. To not commit dist files, I think is correct. Maybe this should be in the gitignore and use the force in each release. On the other hand, if you adopt this way, could be useful to have a release each 2 weeks if there are any changes.

My two cents ;)

Yes, can we also agree on a coding style ? Because the sometime lack of curly braces caused many mistakes...

// don't do this, please !
if (true)
    console.log('hello');

// do this, please !
if (true) {
    console.log('hello');
}
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Atiladanvi picture Atiladanvi  路  4Comments

ndro picture ndro  路  4Comments

reardestani picture reardestani  路  5Comments

sjordan1975 picture sjordan1975  路  5Comments

jewbetcha picture jewbetcha  路  3Comments