Vue-form-generator: add "autocomplete" attr to input fields

[icebob]

Same as "readonly". Add to every field which contains input element.
Example schema:

        let schema = {
            type: "text",
            label: "E-mail",
            model: "email",
            readonly: false,
            autocomplete: true,
            placeholder: "Field placeholder"
        };

Example template of field:

    input.form-control(type="email", v-model="value", :readonly="schema.readonly", :disabled="disabled", :placeholder="schema.placeholder", :autocomplete="schema.autocomplete")

[lionel-bijaoui]

I'm doing it
EDIT: Done #63

[icebob]

Great!

[lionel-bijaoui]

I fixed the problems, can you merge now ?

[icebob]

Need test cases too.

[lionel-bijaoui]

Does all of this count toward a new version ? 0.4.1 ?
If yes, could you do a milestone linked to the issue/PR ?
It is easier for me to know what's missing. Thank you.

[icebob]

Ok, I did.

[lionel-bijaoui]

Thank you. #50 and #62 count toward what goal ?
I just want to have an idea of the roadmap for the plugin.

[icebob]

62 is only docs, I linked to #64. #50 added to v0.5.0

[lionel-bijaoui]

Wait, you mean custom fields are working ?

[icebob]

Yes, I think it is working already, just need to test it.

[lionel-bijaoui]

Awesome !

[lionel-bijaoui]

@icebob For the test case, I propose to group attribute checking under "check optional attribute" inside "check template" :

describe("check optional attribute", () => {
    it("should set autocomplete", () =>{
        field.autocomplete = true;
        vm.$nextTick( () => {
            expect(input.autocomplete).to.be.true;
            field.autocomplete = false;
            done();
        });
    });

    it("should set disabled", (done) => {
        field.disabled = true;
        vm.$nextTick( () => {
            expect(input.disabled).to.be.true;  
            field.disabled = false;
            done();
        });
    });

    it("should set placeholder", (done) => {
        field.placeholder = "Placeholder text";
        vm.$nextTick( () => {
            expect(input.placeholder).to.be.equal("Placeholder text");
            field.placeholder = "";
            done();
        });
    });

    it("should set readOnly", (done) => {
        schema.readonly = true;
        vm.$nextTick( () => {
            expect(input.readOnly).to.be.true;  
            schema.readonly = false;
            done();
        });
    });
});

[icebob]

Good idea

[lionel-bijaoui]

You will see in the PR #63 that I did a little more, and created a function checkAttribute in util.js so that we can write:

describe("check optional attribute", () => {
    // name which attributes you want to test and that's it.
    let attributes = ["disabled"];

    attributes.forEach(function(name) {
        it("should set " + name, function(done) {
            checkAttribute(name, vm, input, field, schema, done);
        });
    });
});

I hope we can merge now :sweat_smile:

[icebob]

Good stuff!

[lionel-bijaoui]

You are back ! :D

[lionel-bijaoui]

@icebob What's blocking this milestone ?

[icebob]

Only my free time :smile: