Vue-form-generator: Create unit tests for new fields

[icebob]

• [x] fieldCleave
• [x] fieldMasked
• [x] fieldNoUiSlider
• [x] fieldPikaday
• [x] fieldSlider
• [x] fieldSpektrum
• [x] fieldVueMultiSelect
• [x] fieldGoogleAddress

[lionel-bijaoui]

I'm going to try after I read a bit more about Karma

[icebob]

OK, but firstly I have to solve the external lib loading problem.

[icebob]

I added external libs to karma. So now can be improve new fields unit tests. https://github.com/icebob/vue-form-generator/commit/776f6c479fec8105df55d69288a310cf58b2386c

[lionel-bijaoui]

(I was about to suggest that :smile: )

---

Passing arrow functions (“lambdas”) to Mocha is discouraged

From the doc
Should we change that ?

[icebob]

Oooo.... what?!?!

[lionel-bijaoui]

basically, don't do this:

describe('my suite', () => {
  it('my test', () => {
    // should set the timeout of this test to 1000 ms; instead will fail
    this.timeout(1000);
    assert.ok(true);
  });
});

but this:

describe('my suite', function() {
  it('my test', function() {
    this.timeout(1000);
    assert.ok(true);
  });
});

[icebob]

You can use arrows because we use webpack as preprocessor and webpack use babel

[lionel-bijaoui]

Unit test are going through Webpack ? Wow ok, I didn't know... Webpack does everything :astonished:

[icebob]

yes :) https://github.com/icebob/vue-form-generator/blob/master/test/unit/karma.conf.js#L35

[lionel-bijaoui]

Sorry, I missed that totally

[icebob]

Nop, so you can use any ES6 feature

[lionel-bijaoui]

Sweet!

[icebob]

what field test are you make? Because I plan to make an other field tests

[lionel-bijaoui]

I'm starting with #36

[icebob]

What we need to test in this external fields:

• [ ] check HTML elements (example: https://github.com/icebob/vue-form-generator/blob/master/test/unit/specs/fields/fieldSelect.spec.js#L48 )
• [ ] after init check the lib read the value from model and value is correct (example: https://github.com/icebob/vue-form-generator/blob/master/test/unit/specs/fields/fieldSelect.spec.js#L63 )
• [ ] if model value changed, check the lib got the new value (example: https://github.com/icebob/vue-form-generator/blob/master/test/unit/specs/fields/fieldSelect.spec.js#L78 )
• [ ] if lib value changed (via HTML element, maye need a trigger with js), check the model got the value (example: https://github.com/icebob/vue-form-generator/blob/master/test/unit/specs/fields/fieldSelect.spec.js#L87 )

[icebob]

I make fieldMasked and fieldSpektrum

[lionel-bijaoui]

I'm going to try fieldVueMultiSelect even if fieldNoUiSlider is not finished

[icebob]

Ok, for multiselect I recommend you to use fieldSelectEx.spec.js as a base

[lionel-bijaoui]

Roger that ! :)

Le 23 août 2016 16:46, "Icebob" [email protected] a écrit :

Ok, for multiselect I recommend you to use fieldSelect.spec.js as a base

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/icebob/vue-form-generator/issues/40#issuecomment-241755645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT81G25O1xKPQyHtgIWx081dxjo6zNEks5qiwfcgaJpZM4JpX4g
.

[lionel-bijaoui]

46 I did something wrong with the branch (a bad rebase), so this one contain a lot a commit from #44.

I hope it's ok.

[icebob]

Ok, #46 & #44 merged

[lionel-bijaoui]

It was too early for #44, I made several mistakes that I'm fixing

[icebob]

Ok, just #46 contains #44 because both was in the same branch, so I can only merge both

[lionel-bijaoui]

My bad sorry about that

[icebob]

Nop :)

[icebob]

fieldMasked done.

[icebob]

fieldPikaday, fieldSlider done.

[icebob]

fieldSpectrum done.

[icebob]

fieldGoogleAddress "done"

[lionel-bijaoui]

Wow cool, you are on :fire:

[icebob]

Now I start the last fieldCleave too.

[icebob]

All test done. :tada:

I made some changes, so if you open the karma debug page ( http://localhost:9877/debug.html ) for test debugging, you will see a similar page instead of empty white blank page :smile:

[lionel-bijaoui]

That's so cool ! I need your help with the doc:

• [ ] visible & disabled, values schema functions description
• [ ] fieldSubmit
• [ ] customizable styles

I hope we can finish everything early next week.

[icebob]

Merged #51