Vue-dropzone: vdropzone-queue-complete doesn't pass parameter arguments

Created on 13 Nov 2018  路  8Comments  路  Source: rowanwins/vue-dropzone

Describe the bug
It seems like vdropzone-queue-complete doesn't pass the arguments as stated in the dox (file, xhr, message).

To reproduce
Goto: https://codesandbox.io/s/xlr3lq2zzo
Open the console
Click Process Queue
See that the arguments (file, xhr, formData) are undefined

first-timers-only

Most helpful comment

I am starting my contribution for open-source and I want to handle this issue.

All 8 comments

Hi @TurboTobias

Thanks for the report, indeed it looks like the argument's aren't being passed through (see here).

This would make a great first task if anyone would like to take a look!

Cheers
R

I am starting my contribution for open-source and I want to handle this issue.

Great thank you @shraiysh - sing out if you need any help :)

Hey @rowanwins , how do I get the values inside the function in the line mentioned? Am I supposed to return a file from vm.files? Is it that I only have to change the prototype of the function and emit lines to suit it the docs just the way others are? Please help me out a little here!

HI @shraiysh

Actually it turns out I've mislead you a little bit sorry!

The queue-complete event doesn't actually send any arguments, so it's our docs which are incorrect. If you look at the original dropzone documentation you can see that.

So it's still a good beginner task, it's just a minor tweak to the docs over here, you just need to remove the stuff between the ()'s

Hopefully that makes sense :)

Thanks, @rowanwins I have made the change and submitted a pull request! Please let me know if there's an issue!

Have a nice day! :)

Great work @shraiysh - resolved by #392

Hey @rowanwins, this was my first pull request to an open source project. Thanks for your help.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jd-0001 picture jd-0001  路  5Comments

syrex88 picture syrex88  路  6Comments

dainemedia picture dainemedia  路  4Comments

zhangzhen picture zhangzhen  路  3Comments

ServerJunge picture ServerJunge  路  5Comments