
It was not clear to me that initializing the folder as a git repo will lead to committing all the files with 'init' as a commit message. I thought if I didn't write an initial commit message, that means it will just initialize it as a git repo. I think committing all the files shouldn't be a side effect of initializing the repo. I suggest making that more clear by stating that 'init' is the default commit message if you don't choose one.
Thank you for the great Vue UI. :sparkles:
Hi @kerolloz! Adding the init commit is also exactly the default behavior when initializing a new project with vue create instead of vue ui. I think it makes sense to have the same behavior using both options. What do you think?
In any case, maybe changing the input placeholder from A to B or C, following the language used in the rest of that form, could make this more clear:
A. _Initial commit message (optional)_
B. _Overwrite initial commit message (optional)_
C. _Type an initial commit message (optional)_
/cc @Akryum because https://github.com/vuejs/vue-cli/pull/1541.
Hi @gtsiolis
I totally agree with you. Yeah same behavior for both options.
I like option B or anything similar. The most important thing is that It's clear that there is an initial commit message not just git repo initialization.
Sounds good @kerolloz! I've added a simpler version of B in https://github.com/vuejs/vue-cli/pull/5329/files#diff-08505d20b45fb530abc924ab6c35b9a6R302. Let's see what others think. 馃弨
Since https://github.com/vuejs/vue-cli/pull/5329 has been merged, maybe it's ok to close this unless I'm missing a development flow that needs this to be open until it reaches master. WDYT? /cc @kerolloz @sodatea
Yeah I forgot to close it in the commit message.
Thank you all!
Most helpful comment
Yeah I forgot to close it in the commit message.
Thank you all!