Vue-carousel: Bug: pageChange not emitted after drag events

Created on 6 Mar 2018  路  4Comments  路  Source: SSENSE/vue-carousel

Hi, I noticed that pageChange is not emitted after a drag, both with mouse and with touch.
Everything works fine when the current slide changes by a navigation or pagination button.

Tested using
vue 2.5.13
vue-carousel 0.6.9
Firefox, Chrome and Safari at the latest versions

Thanks 馃憤

bug help wanted

Most helpful comment

Hey guys, just wanted to give a heads up that @jdtzmn's fix was released (finally) this morning. Sorry for the delay and thanks for contributing 馃帀

All 4 comments

Hey @bepi-roggiuzza, release 0.6.7 changed the way our events were emitted - it should have been backward compatible but there has already been a case where this wasn't true. There is a fix in progress now that will hopefully resolve this, I'll ping you here when it's out!

In the meantime, if you find a solution yourself feel free to share!

I fixed this in my pending pull request: #152

All it took was adding a watcher to the currentPage value and emitting a pageChange event from that.

Thanks @jdtzmn, really appreciated.
I was very busy at work so I didn't make it by myself, but the idea was the same as yours ;)

Hey guys, just wanted to give a heads up that @jdtzmn's fix was released (finally) this morning. Sorry for the delay and thanks for contributing 馃帀

Was this page helpful?
0 / 5 - 0 ratings