Vtk-js: Why doesn't the manipulator's onMouseUp have position?

[mix3d]

Looking at the vtkInteractorStyleManipulator and associated mouse manipulators, why was the API designed to not have position for MouseUp? JS events for mouseUp do have position.

This seems like an oversight, but fortunately one that would result in only a minor revision change since the API for manipulators is publicAPI.onButtonUp = (interactor) => {};, leaving space for 2 more params, renderer and position.

Additionally, the old API documentation at compositeCamera manipulator, (which really should be compositeMouse manipulator), says it should be onButtonUp(eventX, eventY, vtkRenderer, vtkRenderWindowInteractor), which references what I'm assuming an API prior to refactoring to a position object.

[jourdain]

Probably because the move and down give it so if you need it, you can capture those info.

[jourdain]

Also the up could be outside of the RenderWindow.

[jourdain]

Anyhow, we can surely add the same args as the one we provide for any mouse manipulator especially if we have them. .onMouseXXX(model.interactor, callData.pokedRenderer, callData.position)

[mix3d]

So TLDR; no REAL reason, and you'd accept a PR to add them in?

[jourdain]

yes ;-)