Vstest: Avoid usage of JsonConvert in test host process

[ObeA]

Putting the following code in a test case, or executing something like this some where in your application wil cause tests to run indefinitely. My guess it is messes up the communication with VSTest, because JsonConvert will fall back to the settings returned by JsonConvert.DefaultSettings.

C# JsonConvert.DefaultSettings = () => new JsonSerializerSettings { ContractResolver = new DefaultContractResolver { NamingStrategy = new SnakeCaseNamingStrategy() } }

I've found that JsonConvert is being called here. But replacing it with this.Serialize() doesn't solve the issue so I think it must be used somewhere in TranslationLayer package which isn't open-source(?).

[ShreyasRmsft]

@ObeA can you please provide us with a basic sample repro? Create a github repo with a bare minimum project where this repros and we'll take it from there.

[ObeA]

@ShreyasRmsft you can reproduce it by running the test case in https://github.com/ObeA/vstest-issue-1757.

[ShreyasRmsft]

@ObeA thanks, we'll get back to you on this.

[ShreyasRmsft]

@ObeA this is a definite repro. We have a solution in mind. Will file a high pri bug to get this fixed.

The idea is for the test platform not to use global settings.

[ObeA]

Great! Sounds excellent. Can you give any indication of when this should be fixed?

[ObeA]

@ShreyasRmsft any updates?

[ShreyasRmsft]

@ObeA I have filed a bug, but there's quite a bit on our plate. It might take a while before we get bandwidth to make this fix.

[svatal]

this issue in result crashes both Resharper and Rider
https://youtrack.jetbrains.com/issue/RSRP-471623

[abhishkk]

Fixed.