Vscode: Incorrect locale 'en-US' used everywhere (Electron issue?)

[koxu1996]

• VSCode Version: 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a) x64
• OS Version: ArchLinux x64 5.9.6

Today I upgraded _electron_ from _9.3.3-1_ to _9.3.4-1_ and many extensions stopped working in _VSCode_, due to incorrect locale, eg. Python:

Probably it's related to https://github.com/electron/electron/issues/23272, but I want to let you know.

[wooque]

Same issue here, this message pops in integrated terminal, though it seems it didn't break anything in my setup.

[stakaz]

Same here. For me it breaks lualatex compilation with LaTeX-Workshop extension.

My specifications (I am using arch linux):

Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-15T10:42:48.064Z
Electron: 9.3.4
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 5.9.6-arch1-1

[wooque]

This PR is backported to 9.3.4, could be the culprit https://github.com/electron/electron/pull/26185

[tamuratak]

The VS Code package on Arch Linux is a custom build. The current version of Electron of the official build is 9.3.3. You should report this issue to Arch Linux.

• https://github.com/microsoft/vscode/blob/a856e60a0cfcc9609f46855062162e8aa4b69c08/.yarnrc#L2
• https://github.com/archlinux/svntogit-community/tree/packages/code/trunk

[starquake]

Arch Linux splits Electron from VS Code and always has the most recent version available from upstream. It looks like something broke in 9.3.4: https://github.com/electron/electron/issues/26443

So I guess we should wait for an update with a fix.

[lights0123]

I opened that issue in electron's issue tracker after experiencing this exact problem in VS Code, so yes, that is the problem.

[jorgelaranjo]

Upgrade Electron to 10.1.5-1 and VS Code to 1.51.1-1. Clearly at electron as pointed out by https://github.com/microsoft/vscode/issues/110322#issuecomment-725381536

[telmotrooper]

For anyone having this issue on Arch Linux, downgrade package electron9 from 9.3.4 to 9.3.3.

curl -O https://archive.archlinux.org/packages/e/electron9/electron9-9.3.3-1-x86_64.pkg.tar.zst
sudo pacman -U electron9-9.3.3-1-x86_64.pkg.tar.zst

You'll probably want to add electron9* to IgnorePkg in /etc/pacman.conf, so the next time you update your packages you won't accidentally update this one as well. When a fix has been deployed you can remove this setting...

[endorsystems]

@telmotrooper This works. Thanks!

[ejose19]

@telmotrooper Thanks, be sure to also download the signature (https://archive.archlinux.org/packages/e/electron9/electron9-9.3.3-1-x86_64.pkg.tar.zst.sig) along the package and check pacman.conf so that LocalFileSigLevel = Required(or unset and SigLevel = Required), as you probably don't want to install unsigned packages.

[lights0123]

You can also just do sudo pacman -U /var/cache/pacman/pkg/electron9-9.3.3-1-x86_64.pkg.tar.zst, as you probably have it still cached.

[stuartpb]

Just adding, for anyone looking for a low-hanging-fruit workaround, LC_ALL=en_US.UTF-8 code --lang=en_US.UTF-8 --set-lang=en_US.UTF-8 (ie. all of the LC_ALL environment variable, old --lang option that the blamed PR said didn't work, and --set-lang option that the PR appears to implement instead) still results in the en-US locale issue appearing in the first terminal you see.

[lights0123]

Yep, because the Electron source code reads the locale passed from the command line, but then immediately overrides it:

https://github.com/electron/electron/blob/ef674025b5e17845e48a4d55721ea1a5583c4d04/shell/browser/electron_browser_main_parts.cc#L385-L387

[lights0123]

The fix has been merged upstream: the next release will include the fix.