Vscode: "Reveal In Side Bar" does not work if the file is opened from external apps

[saschanaz]

• VSCode Version: 1.51.0
• OS Version: Windows 10 19042

Steps to Reproduce:

1. Open a folder
2. Open a file inside the folder, via File Explorer or via GitHub Desktop
3. See the "Open editors" list shows a full path instead of a relative path
4. Try "Reveal In Side Bar"

Does this issue occur when all extensions are disabled?: Yes

I think this is a regression in 1.51.

[isidorn]

I can reproduce this only on Windows. On macOS things seems to work just fine.
The issue seems to be that this check here fails.
So the contextService.isInsideWorkspace wrongly returns false here.

I believe the issue is with the uri when it comes into VS Code via the Open With command, it has the following structure. Notice the leading upper case C. And I believe all URI internally have the lower case driver letter.

So the gist is: "Open With" command should normalize drive letters when feeding uri's into VS Code.

Also assigning to @bpasero and @sandy081 for ideas

Assigning candidate label since it is a regression. Not sure if we should ship as part of recovery but for discussion.

[bpasero]

Could this be https://github.com/microsoft/vscode/commit/b228267d50d474de56cb56c19d151bd8f61b59f0 too, see https://github.com/microsoft/vscode/issues/108535 @jrieken

[jrieken]

Yeah - likely because the uri search tree is not doing implicit normalisations anymore. I'd say the workspace service or workspace-object should make sure to use a canonical uri before looking something up. Not sure this is a candidate tho.

[jrieken]

The smallest fix is to create the search tree with the ignorePathCasing option here: https://github.com/microsoft/vscode/blob/960205b8a06e3fdc283b9a476952620041cba84a/src/vs/platform/workspace/common/workspace.ts#L147

[isidorn]

I am perfectly fine with not doing this is a candidate. Just added label for awarness.

[isidorn]

For users coming to this issue to find more details: we will ship a fix for this issue in vscode stable this or next week.
If you are interested in how we fixed it you can checkout this PR https://github.com/microsoft/vscode/pull/110247

[jrieken]

merged my PR and cherry-picked the change to master. Also, driving the adoption of the better way of doing this: https://github.com/microsoft/vscode/issues/110241