Vscode: regex replace case changing in search
Case changing for a replace with regex in the find widget was implemented in https://github.com/microsoft/vscode/issues/12185. Search has a different implementation and needs a different approach.
@irridia are you planning on looking into this? Either way is fine, but let me know
https://github.com/microsoft/vscode/pull/96128#issuecomment-642187968
roblourens
All 4 comments
I can probably manage a very simplified regex replace that's on the search side. But looking into a full refactor/join of the two implementations, I don't think I have the TS expertise to do that within the time I'd have. I totally get it if you'd rather have a merged implementation, but if feature parity (if not code parity) is okay for now, I can take a look at the parallel take.
irridia
on 1 Jul 2020
That would be fine with me!
roblourens
on 1 Jul 2020
@roblourens see #105101
irridia
on 20 Aug 2020
+1 for this feature
Aypahyo
on 24 Aug 2020
Related issues
biij5698
路
3Comments
trstringer
路
3Comments
lukehoban
路
3Comments
vsccarl
路
3Comments
VitorLuizC
路
3Comments
Most helpful comment
I can probably manage a very simplified regex replace that's on the search side. But looking into a full refactor/join of the two implementations, I don't think I have the TS expertise to do that within the time I'd have. I totally get it if you'd rather have a merged implementation, but if feature parity (if not code parity) is okay for now, I can take a look at the parallel take.