Vscode: Allow custom tree hovers to be markdown

[alexr00]

Currently, the tooltip for custom tree items can only be a string. We should also allow markdown.

[mattacosta]

So I was only able to get my tooltips containing markdown to work by implementing a do-nothing resolveTreeItem() method. Is that supposed to happen? My tree does not need to resolve any data.

[alexr00]

Not supposed to happen. I will take a look.

[alexr00]

However, if you tree is going to have many items it is better to set the markdown tooltip in resolveTreeItem so that you aren't creating all that markdown in advance.

[alexr00]

@mattacosta I pushed a fix that should be available in insiders tomorrow.

[mattacosta]

More feedback: Not sure if anything can even be done about this, but I'm now noticing that it is significantly easier for the cursor to get into the new hovers compared to the native tooltips, thereby preventing them from going away. This makes it more difficult and/or frustrating to select the tree items that it covers.

[alexr00]

I think this is mostly because they are larger, but it would help if the hovers had one of their corners at your mouse, instead of starting where the tree html element starts.

@Tyriar would it be possible to do this?

[Tyriar]

@alexr00 use IHoverOptions.hideOnHover to make the hover go away when you hover over it, this is ignored if you provide actions though.

[alexr00]

@Tyriar would it be possible to have the corner of the hover at the mouse instead of in line with the html element it's attached to?

[Tyriar]

@alexr00 hideOnHover isn't a good enough solution? Is the hiding of tree items too disruptive? Can you show a gif of the issue as I'm not sure how to show it on the tree atm.

[alexr00]

@Tyriar There are things to click and select in the hover, so hideOnHover doesn't sound like something I want to use.

[Tyriar]

If it's at the mouse position though you would need to move the mouse to the right in order to hover it. Is this what you mean?

cc @misolori

[alexr00]

Yep, that's exactly what I mean! That way the behavior is more consistent with the default tooltip and it doesn't obscure all of the tree above it.

[Tyriar]

https://github.com/microsoft/vscode/issues/104058

[usernamehw]

Anything blocking this from moving to Stable?

[alexr00]

Yes, I need to get the hover working properly on resources (files and the like) when they are in the tree. Once that's good, we can move it to stable shortly after.

[jrieken]

• swap argument order
• use ProviderResult