Vscode: Can't search in workspace that includes folder using a FileSystemProvider

[SqrTT]

• VSCode Version: 1.44.0
• OS Version: Ubuntu 18.04.4 LTS

Steps to Reproduce:

1. Open workspace with contains non default file system (file) but with provider defined in plugin
2. Try and search

Does this issue occur when all extensions are disabled?: Yes

/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:4376 No search provider registered for scheme: ccfs, waiting

(anonymous) @ /usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:4376
searchWithProviders @ /usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:4376

(anonymous) @ /usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:4375

processTicksAndRejections @ internal/process/task_queues.js:85

[SqrTT]

I as author of the extension which implements file system provider can't implement search provider since it's only in proposed API.

[roblourens]

Yes, this is proposed API.

https://github.com/microsoft/vscode/issues/73524
https://github.com/microsoft/vscode/issues/59921

[SqrTT]

it is.but right now this is make issue in v1.44.0. Is that expected?

this is not duplicate since this don't ask for feature but rater bug related to this feature.

[SqrTT]

is that expected that users of my extension have to between choose to use file search or work with external file system?

because feature is in proposed stage but causes issues in stable release

PS. please note; v1.43.0 works fine

PPS:

Does this issue occur when all extensions are disabled?: Yes

means issue is not related to the extension. I'm correct?

[SqrTT]

@roblourens please reopen issue since it's not fixed and not duplicate

[SqrTT]

[SqrTT]

@roblourens or @RMacfarlane please suggest how can I fix the issue No search provider registered for scheme: ccfs, waiting without using proposed API for v.1.44.0?

[roblourens]

I'm pretty sure this didn't work in old versions either, the API has never been stable.

[SqrTT]

let's start from scratch. Extension don't use search provider API (TextSearchProvider and FileSearchProvider or any other from proposed).
Extension use registerFileSystemProvider and registers scheme ccfs this was working well for last two years, but starting v1.44.0 users with the extension face issue with broken search with mentioned in subject error.

I don't need proposed API. I need search working again.
At this point I can fix this only by drop off feature which relays on FileSystemProvider.
Is there way to save feature?

[SqrTT]

@roblourens by the way: workspace.registerFileSearchProvider is not available in type definition but available in runtime. Is that ok? Does it means I can use it in to fix the issue?

[RMacfarlane]

@roblourens Maybe this commit is the problem? https://github.com/microsoft/vscode/commit/0e219d4de273bfee5e401830c65abae18d2f0c3f

Would this cause search to wait indefinitely?

[roblourens]

Is this a multiroot workspace where one folder is a normal folder on disk and the second is from the separate scheme? I guess I see the issue then. If that's not it then I guess I don't understand what was being searched before, please explain.

[SqrTT]

correct, workspace has few folders in it with one "virutal" for ccfs

{
    "folders": [
        {
            "path": "ecom-project"
        },
        {
            "name": "Sandbox - FileSystem",
            "uri": "ccfs://current-sandbox"
        }
    ],
    "settings": {}
}

[gjsjohnmurray]

@roblourens this 1.44 regression is likely to affect users of one of my extensions too. Please make the fix a candidate for the 1.44.1 recovery release.

[roblourens]

Yeah I see it. That change was a mistake, I agree that it should be a candidate. Thanks for finding the commit @RMacfarlane, I think the fix is just to revert that and work around this in the smoke test.

[Feder1co5oave]

Hi, I'm getting the following log after the 1.44.0 update whenever I CTRL+P (search hangs and does not show results):

[13934:0413/222622.335701:INFO:CONSOLE(4376)] "No search provider registered for scheme: gitlens, waiting", source: file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js (4376)

disinstalling, reinstalling gitlens or disabling extensions was of no help.

Recreating the workspace fixed it.

Version: 1.44.0
Commit: 2aae1f26c72891c399f860409176fe435a154b13
Date: 2020-04-08T11:22:13.689Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.3.0-45-generic

[mttkay]

I'm having the same problem as @Feder1co5oave . I even uninstalled GitLens but the problem persists. Search is totally broken now.

[mttkay]

That said, how do I manually remove the GitLens search provider?

[roblourens]

This is fixed in Insiders but not stable yet.

[roblourens]

Verification steps:

• Run the fsprovider sample from our extension samples repo
• Run the commands to create a MemFS workspce folder
• Add another workspace folder, some normal folder on your disk
• Do a search
• It should return results from the local folder and ignore the MemFS folder