Vscode: All built in views shall have predefined & unique icons

Created on 31 Mar 2020  路  10Comments  路  Source: microsoft/vscode

Testing https://github.com/microsoft/vscode/issues/93786

I see all panel views have icons and when they are moved to activity bar these icons are shown. In the same way we shall also have unique icons for other predefined views.

For eg:

  1. . Outline view

image

  1. Open Editors

image

  1. Timeline

  2. Debug views

image

@misolori @jrieken @isidorn @eamodio FYI

icons-product workbench-views

Most helpful comment

This one is hard because some feel like they need one (timeline, outline, npm scripts) but others don't (open editors, debug views, enabled/disabled/recommended extensions). For the ones that don't need one, we could re-use their parent icon?

All 10 comments

This one is hard because some feel like they need one (timeline, outline, npm scripts) but others don't (open editors, debug views, enabled/disabled/recommended extensions). For the ones that don't need one, we could re-use their parent icon?

We should allow custom view to also contribute an icon as well.

@eamodio I believe that's the plan so far

Here's my suggestions so far (these already exist in codicons):

  • Timeline => history
  • Outline => symbol-class
  • NPM Scripts => code

image

@misolori Timeline should be history right?

@eamodio sorry yea, they're mapped to the same icon (though the codicon preview page doesn't show that).

@misolori your suggestion makes sense.
If we already have a nicely suited codicon we should use it.

@sbatten let me know if there is anything else you need from me.

We will need #93968 for NPM Scripts @sandy081

@misolori we now have everything we need to supply icons. all debug views are currently using the same icons and npm scripts needs an icon svg i think since it is an extension

Was this page helpful?
0 / 5 - 0 ratings