Vscode: Magnifiers caret following is not working in the Terminal view

Created on 3 Dec 2019  路  12Comments  路  Source: microsoft/vscode

  • VSCode Version: 1.40.2
  • OS Version: Windows 10 x64

Steps to Reproduce:

  1. Open VS Code and the windows magnifier app (type "magnify" in windows menu)
  2. In Magnify settings, check the options to follow keyboard input
  3. In VS Code, create a new file, type several lines of text, notice how the magnifier is following properly.
  4. Open a terminal view (PowerShell or CMD), and type text, notice how the magnifier cannot follow the input
accessibility bug help wanted insiders-released integrated-terminal upstream upstream-issue-fixed upstream-issue-linked verified

Most helpful comment

All 12 comments

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

For the magnifier to work the Terminal would have to have the hidden text input field like the editor does. The textInputField would always be in sync with the content of the Terminal.
@Tyriar assigning to you. We do not currently have the hidden text input field in the terminal correct?

@isidorn yeah it does uses a hidden text field, it's not in sync due to an old IE bug though. We don't care about IE support anymore so can probably keep it in sync https://github.com/xtermjs/xterm.js/issues/2598

Yes, that would be great!
This would totaly improve the accessibility in the terminal.
Assigning to December and me also so if I find time I might provide a pr. Code pointer welcome

@isidorn 馃憤 added some code pointers to https://github.com/xtermjs/xterm.js/issues/2598

Thanks. Let's see if some user picks this up. If not I can jump on it.

I would like to work on this please if possible.

@BuraChuhadar thanks a lot for jumping on this. I see you already created a PR. Leaving that one to @Tyriar to review.

PR still needs some iteration, removing from Jan for now

Assigning to June so I look into this if I find time

@jeanp413 thanks a lot for looking into this, great job!

Was this page helpful?
0 / 5 - 0 ratings