Vscode: Touch bar mac disabled on focus file

[Alexzanderk]

So I updated to 1.40.0
And have this issue:
my touch bar on mac hide! What I mean
When I write code this is showing my touch bar

but early it was

My settings

When the focus is down from the code window
touch bar show

I expected behavior on the focus code window
this

but have this

What happened with the touch bar?

[vscodebot[bot]]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Mac OS touch bar (#84189)
• problem about touch bar (#82340)
• Touch Bar icon appearance does not comply with macOS Human Interface Guidelines (#72047)
• Touch support can be improved in webviews (#21812)
• Sidebar minimap/scroll doesn't work with surface touch screen (#75672)
  

[luannguyend86]

@Alexzanderk yes, it is the same to me at #84189

[bpasero]

@Alexzanderk what are these other items in the touchbar you show, are they coming from macOS?

[vscodebot[bot]]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[guidobouman]

The words you see are the spelling autocomplete words provided by Apple. They are coming from macOS as autocorrect. As soon as the with of the spell check hits an otherwise visible button, that button is hidden.

You can check that behaviour by collapsing the autocomplete through tapping on the (small) arrow on the left.

In my case: On a 13" MacBook pro I can start the project, but I can't stop the project. The start state on the touch bar is small enough to show, but the debugging state is wider, and hits the collapsed autocomplete, and is thus always hidden.

Start state

Debug state:

Width of expanded autocomplete, hiding both start & debug state

[bpasero]

VSCode is built on top of a large number of components that are not maintained by the VSCode team directly. This includes:

• Electron as the cross platform UI framework
• node.js for most integration into the OS
• Chromium as runtime and rendering engine (HTML, CSS, JS)
• and after all, the operating system VSCode is running on

Reading this issue, it seems to originate not from VSCode itself but rather one of these upstream components. As such, in order to resolve it, it would need to get fixed in the upstream component. I will go ahead and close this issue and kindly ask to report this issue to the upstream component if possible:

• for UI, OS integration: https://github.com/electron/electron
• for Rendering: https://bugs.chromium.org/p/chromium/issues/list
• for file IO: https://github.com/nodejs/node

Thanks for understanding.

[Alexzanderk]

@bpasero I downgrade to 1.39
and on this version, everything is fine to work like expected

[guidobouman]

It's a thing in a Chromium release. I'm wondering if it's configurable to remove text suggestions on an input field.

Adding autocomplete="off" on the textarea I'm typing this in does not remove the suggestions.

Tracking issue for Electron:
https://github.com/electron/electron/issues/9349

Tracking issue for Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=717553

[bpasero]

If someone is willing to report this issue to Electron we can reopen this one and link to the issue. But there is currently probably nothing we can do in VSCode given that autocomplete="off" does not seem to help.

[Alexzanderk]

It's a thing in a Chromium release. I'm wondering if it's configurable to remove text suggestions on an input field.

Adding autocomplete="off" on the textarea I'm typing this in does not remove the suggestions.

Tracking issue for Electron:
electron/electron#9349

Tracking issue for Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=717553

Chromium?? Why do you think that issue with chromium?

[guidobouman]

Chromium?? Why do you think that issue with chromium?

Did you read the links I attached? macOS provided a feature that Chromium later implemented. VS Code updated their version of Electron, which in turn updated their version of Chromium in the meantime. So we need to find a way to disable this in Chromium through an HTML attribute or in Electron through config, if that is even possible.

[guidobouman]

@bpasero The chromium team picked this up rather quickly; A fix already landed in their repo. See https://bugs.chromium.org/p/chromium/issues/detail?id=1024914 for more tracking info.

This should hide the TouchBar suggestions when adding autocomplete="off" on a textarea. Would that work for VS Code?

[bpasero]

@deepak1556 can we possibly backport this change for Electron 6?

[deepak1556]

@bpasero yup seems simple enough to target recovery release.

[bpasero]

@deepak1556 I think November is fine, I was not suggesting recovery :)

[deepak1556]

Electron PR https://github.com/electron/electron/pull/21191

[Alexzanderk]

This should hide the TouchBar suggestions when adding autocomplete="off" on a textarea. Would that work for VS Code?

Where is I need to add autocomplete="off"?

[guidobouman]

This needs to be done by the VS Code team. Probably as a setting to, keep users, who prefer autosuggest, happy.

[bpasero]

I don't think we want a setting for this, the editor disables autocomplete by default for various reasons.

Rather I think it would be nice to have an attribute on the element that allows to opt-in to touchbar suggestions and then maybe that could be a setting.

Maybe @alexandrudima can comment on why autocomplete is off in the text area specifically.

[alexdima]

autocomplete is off in the editor <textarea> for performance reasons. We don't have the actual file content in the <textarea>, we only have the previous character and suggestions wouldn't be helpful. We only place the previous character because everything more we place in there will cost in terms of performance.

[guidobouman]

Sure, but I also remember seeing an issue that requested the feature in this repository. (Can't seem to find the issue right now...)

[deepak1556]

Fixed with https://github.com/microsoft/vscode/pull/85266