Vscode: Can't type quotes with US INTL on Windows

[alexdima]

Moved from https://github.com/MicrosoftDocs/vsonline/issues/68

From @sadasant

---

I'm using VSCode online, the web version, and I'm unable to type single quotes, double quotes and symbols like `.

I am using US International as my keyboard layout locally. The online editor does let me write accented letters, like: áéíóú, etc.

So far I've been managing by copying and pasting these symbols. It hasn't stopped me from using the site, but it is kind of weird.

I'm using Chrome version 78.0.3904.70 (Official Build) (64-bit) on the latest available Window version.

[alexdima]

This must be a recent regression since the editor at https://microsoft.github.io/monaco-editor/ allows quotes to be typed.

[sadasant]

This must be a recent regression since the editor at https://microsoft.github.io/monaco-editor/ allows quotes to be typed.

I can confirm this too! 🌞

[alexdima]

I cannot reproduce when loading only the standalone editor, but I can reproduce when loading the entire workbench.

Also, interestingly, no native <input> accepts an accent like ' + space. The results is always a space in the <input>...

[alexdima]

Interestingly, this has to do with the keybinding service where if I comment out the following section I can type again quotes:

https://github.com/microsoft/vscode/blob/308ff31f9585211a12e95afbab6829c088b2bc72/src/vs/workbench/services/keybinding/browser/keybindingService.ts#L220-L226

[alexdima]

Ok, further progress... commenting out this specific line will allow typing quotes to work again -- https://github.com/microsoft/vscode/blob/308ff31f9585211a12e95afbab6829c088b2bc72/src/vs/workbench/services/keybinding/browser/keybindingService.ts#L415

[alexdima]

OK, @rebornix, AFAICT the following is happening:

• when first typing Quote
• the mapping is invalidated because Quote does not produce ', because it is a dead key in this context
• we then call navigator.keyboard.getLayoutMap()
• I can only assume Chromium implements this in a similar way we have implemented it in node-native-keymap, which is to call MapVirtualKeyW. As part of doing that, you must clear the current keyboard state...

TL;DR -- two issues:

• the US layout is permantently invalidated at each keystroke which makes it always reload itself... we should protect against such behavior...
• calling navigator.keyboard.getLayoutMap() while composition is taking place ruins the keyboard state

[rebornix]

@alexandrudima thanks for the detailed analysis. That's what's happening indeed.

[sadasant]

Just to report something else: This also happens with some symbols, like ` and ^. I'm guessing this is related to accentuation, but áéíóú work, for example.

[rebornix]

Verified that now VS Code Web handles ' or ` the same as native app.