Vscode: Reload should preserve maximized panel

[isidorn]

Refs: #79845

1. Maximize the panel
2. Reload
3. Panel is not maximized 🐛

Marking as a feature request since we never had this feature since panel could never be full height.
The ugly part about this flow is that we forget the previous size of the panel before the user maximized it (so he can not go back with a click)

[isidorn]

Also instread of reload you can toggle panel visibility via ctrl/cmd + j. That should aslo preserve the maximized panel

[sbatten]

hmm, thanks for the feedback. The benefit of today's behavior is that if a user accidentally hides the editor and can't get it back, a reload will always reset it and I don't anticipate a lot of people leaving the editor hidden across sessions. Also imagine the following scenario regarding your second point.

1. I maximize the terminal to do some work. (The goal being to see the terminal, not hide the editor)
2. I then hide the terminal to get back to coding. This shows the editor and feels right from the user's perspective.
3. I then show the terminal again for a quick command. Do I necessarily want the editor to be gone? I don't really know the answer to this, but I feel like the answer is no.

[sbatten]

one thing I should probably do and might feel better is make sure that if we do bring the editor back from a hidden state on restore, the panel is not almost maximized but rather its previous unmaximized state

[isidorn]

Agree that the panel in a not almost maximized state never makes sense since the user looses the previous unmaximized state.

However I would still prefer that the panel remains maximized. Since the user can always click on the editor in the explorer / open editors view / quick pick and to get out of this mode. And you handle it already very nicely. So I am not worried about user being stuck at all.

Though I would love to hear the opinion from @tyriar since he is very passionate about this

[sbatten]

@isidorn I see your points. I attempted store the editor state and use it on launch but because of other eventing, the editor area gets restored anyway. I need to look more deeply to get the right fix for this. In the interim, I have pushed a fix that stores the editor visibility and uses that to set the panel back to its pre-maximized state.

[isidorn]

@sbatten thanks. That's fair. I do not think this is urgent for August. We can always look into it next milestone when we have more time.

[Tyriar]

Though I would love to hear the opinion from @Tyriar since he is very passionate about this

I think the main users this would help right now are those that want to use a window as a dedicated terminal window which isn't me. However, it would be very useful when we get into the business of restoring terminals across sessions if they are the same size. Even better if the panel is correctly positioned right from the beginning before the terminal starts up.

[konstlepa]

Also instread of reload you can toggle panel visibility via ctrl/cmd + j. That should aslo preserve the maximized panel

It doesn't preserve the original panel's size😔

This bug is very annoying because I use the shortcut cmd-j very often.