Vscode: Cannot read property 'Symbol(Symbol.iterator)' of t.push

Created on 6 Jul 2019 · 26Comments · Source: microsoft/vscode

Issue Type: Bug

Mark multi lines like this:
https://i.imgur.com/wYNpGbz.png

And press TAB now it shows this:
https://i.imgur.com/7fHKIGG.png

Shift + TAB works btw.

VS Code version: Code - Insiders 1.37.0-insider (7e03eb1a1fce3beb6ccea5f3b8f828e01940be61, 2019-07-05T18:31:56.611Z)
OS version: Windows_NT x64 10.0.18362

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz (4 x 3392)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled|
|Load (avg)|undefined|
|Memory (System)|23.94GB (13.77GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

Extensions (34)

Extension|Author (truncated)|Version
---|---|---
path-intellisense|chr|1.4.2
vscode-markdownlint|Dav|0.28.0
vscode-eslint|dba|1.9.0
githistory|don|0.4.6
gitlens|eam|9.8.2
vscode-npm-script|eg2|0.3.8
vue-inline-template|fai|1.0.1
vue-format|feb|0.1.7
code-runner|for|0.9.11
vscode-test-explorer|hbe|2.12.1
beautify|Hoo|1.5.0
discord-vscode|icr|3.6.0
Angular2|joh|8.1.1
graphql-for-vscode|kum|1.14.1
vscode-mocha-sidebar|mat|0.22.2
Angular-BeastCode|Mik|8.0.10
vscode-docker|ms-|0.6.4
python|ms-|2019.6.22090
csharp|ms-|1.20.0
vscode-typescript-tslint-plugin|ms-|1.2.1
vsliveshare|ms-|1.0.488
team|ms-|1.149.2
debugger-for-chrome|msj|4.11.6
vetur|oct|0.21.1
material-icon-theme|PKi|3.8.0
java|red|0.46.0
vscode-yaml|red|0.4.1
es6-mocha-snippets|spo|0.2.2
vscode-java-debug|vsc|0.20.0
vscode-java-test|vsc|0.18.1
vscode-maven|vsc|0.17.1
quokka-vscode|Wal|1.0.233
JavaScriptSnippets|xab|1.7.2
html-css-class-completion|Zig|1.19.0

needs more info snippets

Source

DaniGTA

👍8

Most helpful comment

I get this error message when I press tab on a line in vscode

rainzhao2000 on 8 Jul 2019

❤3 👍3 👀1

All 26 comments

Same here on linux

RobinMarchart on 6 Jul 2019

Can you open devtools (help menu) and paste in the stack trace from the console?

Tyriar on 6 Jul 2019

Stacktrace @Tyriar
ERR Cannot read property 'startLineNumber' of null: TypeError: Cannot read property 'startLineNumber' of null
at i._editor.getModel.changeDecorations.e (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2313:187)
at P._changeDecorations (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1204:16)
at P.changeDecorations (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1203:366)
at v.move (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2312:962)
at b._move (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2320:268)
at b.next (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2319:985)
at e.next (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2324:408)
at Object.handler [as _callback] (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:2325:82)
at Object.runEditorCommand (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1575:586)
at n.invokeWithinContext.e (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1575:853)
at d.invokeFunction (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1397:380)
at e.invokeWithinContext (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1917:551)
at Object.runCommand (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1575:724)
at handler (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1575:88)
at d.invokeFunction (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:1397:380)
at Proxy._tryExecuteCommand (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:3053:170)
at r.then.i (file:///usr/share/code-insiders/resources/app/out/vs/workbench/workbench.main.js:3052:907)

RobinMarchart on 6 Jul 2019

OnWindows:

 ERR Cannot read property 'startLineNumber' of null: TypeError: Cannot read property 'startLineNumber' of null
    at i._editor.getModel.changeDecorations.e (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2313:187)
    at P._changeDecorations (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1204:16)
    at P.changeDecorations (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1203:366)
    at v.move (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2312:962)
    at b._move (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2320:268)
    at b.next (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2319:985)
    at e.next (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2324:408)
    at Object.handler [as _callback] (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2325:82)
    at Object.runEditorCommand (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1575:586)
    at n.invokeWithinContext.e (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1575:853)
    at d.invokeFunction (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1397:380)
    at e.invokeWithinContext (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1917:551)
    at Object.runCommand (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1575:724)
    at handler (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1575:88)
    at d.invokeFunction (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1397:380)
    at Proxy._tryExecuteCommand (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:3053:170)
    at r.then.i (file:///C:/Users/danig/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:3052:907)

DaniGTA on 6 Jul 2019

same issue(
-1562478722102.log

SupinePandora43 on 7 Jul 2019

I got the same issue.

yc-codes on 8 Jul 2019

I get this error message when I press tab on a line in vscode

rainzhao2000 on 8 Jul 2019

❤3 👍3 👀1

@DaniGTA (or anyone else experiencing this issue), does this also happen when all extensions are disabled? I haven't been able to reproduce this yet

RMacfarlane on 8 Jul 2019

I think that comes after a while when i start vscode i dont get this bug instand, it comes with the time.

But if it is a extensions, all that experience the bug should post there extensions so that we can find out what extension make that bug.

DaniGTA on 8 Jul 2019

+1 Same issue when i hit tab - key (on mac os x)

Problem goes away if i restart vscode - insiders.

Version: 1.37.0-insider  
Commit: d50852db1af10ec100a71ad57cc3a04c8aead117  
Date: 2019-07-08T05:33:31.335Z  
Electron: 4.2.5  
Chrome: 69.0.3497.128  
Node.js: 10.11.0  
V8: 6.9.427.31-electron.0  
OS: Darwin x64 18.6.0

mtin79 on 8 Jul 2019

👍3

t-eckert on 8 Jul 2019

If you're experiencing this issue, can you please

Indicate if this happens only in 1.37 insiders, or if you are using stable
Try running the Developer: Reload Window With Extensions Disabled command

RMacfarlane on 8 Jul 2019

👍2

Same here on latest Insiders, MacOS:

Version: 1.37.0-insider
Commit: d50852db1af10ec100a71ad57cc3a04c8aead117
Date: 2019-07-08T05:33:31.335Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

After hitting Tab key to get auto-complete for a snippet, in Javascript (straight .js and .vue) files.

After extensions disabled (and before they were disabled), am getting (lots of):

lifecycle.ts:124 Error: Registering disposable on object that has already been disposed of
    at l.add (lifecycle.ts:124)
    at e._doInsert (snippetController2.ts:119)
    at e.insert (snippetController2.ts:74)
    at e._insertSuggestion (suggestController.ts:197)
    at e.acceptSelectedSuggestion (suggestController.ts:329)
    at Object.handler [as _callback] (suggestController.ts:420)
    at Object.runEditorCommand (editorExtensions.ts:142)
    at n.invokeWithinContext.e (editorExtensions.ts:165)
    at d.invokeFunction (instantiationService.ts:67)
    at e.invokeWithinContext (codeEditorWidget.ts:362)
    at Object.runCommand (editorExtensions.ts:158)
    at handler (editorExtensions.ts:90)
    at d.invokeFunction (instantiationService.ts:67)
    at Proxy._tryExecuteCommand (commandService.ts:81)
    at r.then.i (commandService.ts:70)

Snippets aren't showing, because the language specific extension isn't loaded, so of course it's going to work...

jtsom on 8 Jul 2019

tabbing 1 line and tabbing multiple lines work for me now on
Version: 1.37.0-insider (user setup)
Commit: d50852db1af10ec100a71ad57cc3a04c8aead117
Date: 2019-07-08T05:37:36.104Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

rainzhao2000 on 8 Jul 2019

@jrieken Based on the call stack, I think this is at https://github.com/microsoft/vscode/blob/6b88a5364546109b6bec8b56873aa8a51b4005b6/src/vs/editor/contrib/snippet/snippetSession.ts#L153

RMacfarlane on 8 Jul 2019

I cannot reproduce, can someone share reproduce steps, esp. the source file in which this happens. Thanks

jrieken on 9 Jul 2019

Likely fixed by https://github.com/microsoft/vscode/commit/b29fec000b96d7912d56499a496284156c9aa891

jrieken on 9 Jul 2019

Optimistically closing.

jrieken on 9 Jul 2019

😄2

Still exists on insiders build.

Reproduction

Literally any .ts file after a while of coding, does not happen on fresh start or after force reload of vscode.

Version: 1.37.0-insider
Commit: d50852db1af10ec100a71ad57cc3a04c8aead117
Date: 2019-07-08T05:33:31.335Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

ERR Cannot read property 'startLineNumber' of null: TypeError: Cannot read property 'startLineNumber' of null at i._editor.getModel.changeDecorations.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2313:187) at P._changeDecorations (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1204:16) at P.changeDecorations (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1203:366) at v.move (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2312:962) at b._move (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2320:268) at b.next (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2319:985) at e.next (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2324:408) at Object.handler [as _callback] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2325:82) at Object.runEditorCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:586) at n.invokeWithinContext.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:853) at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1397:380) at e.invokeWithinContext (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1917:551) at Object.runCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:724) at handler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:88) at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1397:380) at Proxy._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3054:170) at r.then.i (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3053:907)

rumanbsl on 9 Jul 2019

@rumanbsl Latest insiders is 9296aaa2201b638e2b1dc71a9b9fe38c5ab2e904, please try with that one

jrieken on 9 Jul 2019

@jrieken problem disappeared! but it very hard to reproduce, and maybe problem still exists.

SupinePandora43 on 9 Jul 2019

+1
Version: 1.37.0-insider (system setup)
Commit: 7e03eb1a1fce3beb6ccea5f3b8f828e01940be61
Date: 2019-07-05T18:31:56.611Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

dazhoudotnet on 9 Jul 2019

Will report back...

rumanbsl on 9 Jul 2019

Error seems to go away with 46cc0a1670b7047e610aaef1bf84f1190802e9ec

rumanbsl on 11 Jul 2019

On MacOS (7e03eb1)
log.ts:173 ERR Cannot read property 'startLineNumber' of null: TypeError: Cannot read property 'startLineNumber' of null at i._editor.getModel.changeDecorations.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2313:187) at P._changeDecorations (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1204:16) at P.changeDecorations (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1203:366) at v.move (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2312:962) at b._move (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2320:268) at b.next (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2319:985) at e.next (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2324:408) at Object.handler [as _callback] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2325:82) at Object.runEditorCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:586) at n.invokeWithinContext.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:853) at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1397:380) at e.invokeWithinContext (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1917:551) at Object.runCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:724) at handler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1575:88) at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1397:380) at Proxy._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3053:170) at r.then.i (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3052:907)