Vscode: Update to Electron 6

[bpasero]

This plan item is to cover the work of updating to Electron 6. We will skip Electron 5.

PR: https://github.com/microsoft/vscode/pull/75802

Download:

• macOS: Download
• Linux (DEB): Download
• Linux (RPM): Download
• Windows: Download

[beastdestroyer]

Any predictions for when an exploration build which is up-to-date with master is released?

EDIT: if any exploration will be released, which I'm assuming is likely

[bpasero]

@beastdestroyer we plan for July to release first exploration builds.

[leaxoy]

I build this branch locally， and find it resolve the thin font on external display，this looks great， so I's waiting for the exploration one.

[beastdestroyer]

@bpasero Noticed that maximise windows on Windows doesn't work - have to drag from the top and hold it there to expand it (normal Windows "gesture/shortcut")

Also noticed bold font has disappeared?

Make bold text in a .md file and notice only colouring, no styling. Italic works fine

[bpasero]

@beastdestroyer does that reproduce when you configure the window title style to native in settings? Could be a bug from our custom title.

Do you see bold in other places in the editor? Can you maybe open developer tools and see if the style is set?

[beastdestroyer]

@bpasero

1. Setting title bar to native works fine, but the menu becomes this (I have dark mode enabled on windows 10 1903, maybe that's why?)
   

1. It turns out: Yes it is applying the style - it's just much more thinner so it blends in with everything else
   Exploration 1.37:
   
   Insiders 1.37:
   

Used "Fira Code Medium" font

I have noticed the letters themselves are actually more smoother than the insiders version, which is axtually pretty cool; you kinda need to get up a bit close but the discrepancy between the bold and normal weight now seems narrower, which imo should be adjusted :>

[beastdestroyer]

@bpasero
Also noticed when you do get the window maximised, I can't unhide my taskbar (I have auto hide on Windows turned on because I likethe extra screen real estate)

[beastdestroyer]

@bpasero @deepak1556 (Sorry if these pings bother you, idk if I should create separate issues for these or just leave them here)

Just found another bug:

1. Have an editor with the sidebar open to some width that isn't the minimum width
2. Minimise the window (don't just click off the window)
3. Then open the window back - observe the sidebar is now at minimum width

You can try by minimizing and then focusing on another window, then back and the same thing happen

EDIT: Another bug:

Full screen gives weird extra borders around the screen

[bpasero]

@beastdestroyer yeah I think at this point it would help to distill each individual issue separately and then we can add the electron-6.0.x label. Thanks for testing!

[beastdestroyer]

Alright done, there's like 6 issues all with [EXPLORATION] for ya :)

[NashLegend]

Any new releases ?

[cebor]

The last exploration build seems to fix the font issues from: https://github.com/Microsoft/vscode/issues/51132

[lucashtc]

@initialshl Looks like the new releases available here: 75802

[bpasero]

Pushed to master to have it in insiders on Monday.

[beastdestroyer]

@bpasero does this mean exploration won't be updated anymore until another electron update/test is needed? sad times, i love exploration :)

Edit: Is VSCode going to have a regular electron update schedule? For example, every 2 major versions, so the next one would be Electron 8, currently in nightly? Or is it still yet to be discussed?

[bpasero]

does this mean exploration won't be updated anymore until another electron update/test is needed? sad times, i love exploration :)

Yeah, I think we want to move forward with exploration to Electron 7 or 8 pretty soon. Deepak is on vacation right now but we will pick this up again once he is back.

At this time it is not clear to me if we would go with E7 or E8.

[beastdestroyer]

I'd argue go for E8, you guys skipped E5 (perhaps an issue, or it was too far behind and E6 was essentially close to stable) so going for E7 may lag behind schedule? I propose going for every 2 versions because now Emajors are released very frequently

Plus you get to land exactly on E10 which is nice :)

[bpasero]

Given https://github.com/microsoft/vscode/labels/electron-blocker and this being the last day of the milestone, this moves to October.

[kanlukasz]

I hope that Electron 6 will be implemented in October. This solves many problems, including mine

[svipas]

@bpasero Since all blockers are fixed, could we expect next week Insiders with Electron 6?