Vscode: Trojan Coin Miner found in VSCode cache

[RevoluPowered]

• VSCode Version: 1.34
• OS Version: Windows 10

Steps to Reproduce:

1. Install plugins below:
   

1. Scan your user folder with windows defender.
   C:UsersAppDataRoamingCode

Does this issue occur when all extensions are disabled?: Yes, I physically have to delete the cache folder.

[alefragnani]

Hi @RevoluPowered ,

It appears to be related to this post https://code.visualstudio.com/blogs/2018/11/26/event-stream. Looking closer, based on the reported extensions in that post, I see tomoki1207.pdf as being one of the _detected_, so you should contact the author (and any extension) to update its extension.

Also look for the other 3 extensions too, because that's an old post, and some of the extensions may not be listed.

Better yet, uninstall _any_ extension(s), until it has been fixed.

Hope this helps

[egamma]

@RevoluPowered as @alefragnani suggest please uninstall vscode-pdf.

@auchenberg can you do another scan of the extensions.

[RevoluPowered]

In future, I would expect the extensions which are released and distributed in the application are automatically scanned. before they can make it onto a machine through an approval process.

In my opinion it's standard practice to scan anything you distribute using a tool like vscode before allowing a extension publisher to push out potentially malicious code to users.

Please can you look into this as this can be mitigated in future, if the vscode extensions are scanned before they can be pushed to machines.

370,000 installs could have that coin-miner, the issue is with the security model adopted for extensions and I believe it needs looked into.

[RevoluPowered]

Also, what if someone does this to a C/C++ extension and it distributes something worse than just a coin miner?

[DanTup]

It looks like this was raised when the extension was removed by MS, but the extension may have just been re-published as-is?

https://github.com/tomoki1207/vscode-pdfviewer/issues/33

Also, what if someone does this to a C/C++ extension and it distributes something worse than just a coin miner?

Right now extensions have full access to your machine - I think you should treat them like downloading any random executable code from the internet - don't do it if you don't trust the author. There's an issue at https://github.com/microsoft/vscode/issues/52116 asking for sandboxing of extensions, but I suspect it's a big job (and for things like language servers/debuggers it's likely they'll always need full access).

[RevoluPowered]

Right now extensions have full access to your machine - I think you should treat them like downloading any random executable code from the internet - don't do it if you don't trust the author. There's an issue at #52116 asking for sandboxing of extensions, but I suspect it's a big job (and for things like language servers/debuggers it's likely they'll always need full access).

@DanTup I agree but I think we do need stronger measures to prevent this kind of thing in future.

1) Approval route for all publishes on the extension server.
2) A basic antivirus scan of build artefacts before a publish/approval of an extension can be executed, much like Google Play app submissions.

[DanTup]

I don't disagree, I was just saying how it was today (and I linked an issue that is also requesting something in this area - though I've on idea whether it's that feasible or likely to happen).

[RevoluPowered]

Ah okay, yeah it would be neat if this was implemented. I think it will be a good proactive measure to prevent it happening in future.

Yeah I don't know either if they will implement this, but it might save them a headache in the future.

[chrisdias]

I cannot reproduce this and I've verified that the pdf viewer extension has version 3.3.4 of event-stream, which does not have the vulnerability.

Extensions are virus scanned when they are published to the Marketplace.

[RevoluPowered]

I have just confirmed that the version has not changed since I posted this reply and the infection doesn't seem to be caused by that extension.

What else could be the cause of the cache containing the bitcoin miner?

[DanTup]

The foldername has "cache" in it - could it just be old unused stuff? (I've no idea how to verify that, or if it's safe to remove it though..)

[RevoluPowered]

The local/code/cache is generated by electron when it loads up - its spit out by the chromium framework.

It is unlikely to be unused stuff, more likely it was loaded at some point by electron and not thrown away.

[RevoluPowered]

Will be closing this after a full scan completes as this is not part of the most recent update with the same extensions.