Vscode: Tree does not highlight item under context menu if tree does not have focus

[usernamehw]

Issue Type: Bug

1. Try to invoke context menu on Explorer item
2. The item in Explorer is not highlighted

VS Code version: Code - Insiders 1.33.0-insider (9474154f133dbbb793ca3c128c9fcfdca39f5b26, 2019-03-22T06:18:30.063Z)
OS version: Windows_NT x64 10.0.17763

[usernamehw]

In Stable it doesn't work for Custom Trees.

[isidorn]

You first have to click on the tree to give it focus (first clicks in my gif show how the tree first does not have focus).
This works for me. Are you doing something different

edit: deleting gif, it is very iritating

[usernamehw]

So ... more breaking changes? And to the worse... Making 2 clicks instead of 1... just ... why?

If you are using Shift+F10 it doesn't highlight too.

[usernamehw]

Also LMB clicking is opening the file(or executing action in Custom Views), which I don't want to.

[isidorn]

Updating title. Forwarding to @joaomoreno this is a tree issue

[joaomoreno]

@isidorn This is a consequence from https://github.com/Microsoft/vscode/issues/68697.

The item is highlighted, the "focus" trait is indeed there. But since the tree isn't DOM focused, the row doesn't have any background color. Just right click an element and then click in the editor... the element will be highlighted then.

@misolori This is why we go back and forward on this all the time.

[misolori]

Maybe I'm missing something, but I'm able to get a highlight on a tree item when invoking the context menu?

[isidorn]

@misolori first get the focus out of the viewlet.

[misolori]

So it appears this happens when there is no focus on the entire application (in the background) and you attempt to right-click.

@joaomoreno is there any way to apply this highlight when the application window is inactive and not when you're in the app? In that case it makes sense to show a highlight but I also wouldn't want this when I'm in a different part of the editor.

[joaomoreno]

@misolori This also happens in custom menus, regardless of window focus.

[jsunsawyer]

Not sure why my issue was closed as a duplicate, but I hope that this issue can resolve it. See #72013

[misolori]

@isidorn @joaomoreno since #72013 was closed, are we planning on updating this issue to cover the overall focus of the app when it's in the background? Here's a GIF of that issue:

[joaomoreno]

That's more of a question for @bpasero

Though that seems to be a pattern which does not exist on macOS. Try right clicking on any other unfocused app.

[bpasero]

We have a setting window.clickThroughInactive for macOS that controls that. By default we allow to click through.

[Multiply]

We have a setting window.clickThroughInactive for macOS that controls that. By default we allow to click through.

I'm pretty confident that is enabled for me, and when I rightclick (while vscode is not focused) on a folder to create a new file, it doesn't allow me to type anything, as the window didn't get focus.

[jsunsawyer]

Maybe it's more that actions in the right click menu that trigger actions that require focus to interact with should trigger a focus on the app.

[florianrusch]

The description of window.clickThroughInactive says, that the window will be activated and then the element under the mouse will be triggered. But that's not how it work...

If I do a right click, like @misolori showed in his gif, the window will not be activated.

Belongs this bug to this issue? Or should I create a new one?

[misolori]

Given that this issue seems to flop based on this, I'm going to close as wont-fix.