Vscode: Unsaved files are opened in two windows when reopening vscode

[roblourens]

• Open a folder
• Create untitled file with some content
• Quit vscode
• Open vscode
• Two windows are opened, one has the folder +untitled file, other is an empty window + untitled file.

So the same untitled file is opened in two windows.

[Tyriar]

I could only repro this with an empty window:

1. Open Code via finder
2. Close all files/folders
3. Open an untitled file, add changes
4. cmd+q
5. Open Code via finder

[bpasero]

Moving this to @aeschli as the last who touched this code.

[bpasero]

@aeschli for some reason the emptyToRestore array has multiple entries for the same window?

[Heesz]

Temporally until update is not yet, for prevent backup window add to settings "window.restoreWindows": "none"

[SylwesterZarebski]

When set "window.restoreWindows": "all", then every close & start VSCode will multiple windows (1 -> 2, 2 -> 4, 4 -> 6, and so on).
Fix is needed ASAP.

[bpasero]

@aeschli this change is not in the recovery build yet pending https://github.com/Microsoft/vscode/pull/70180 right?

[bpasero]

Pushed.

[roblourens]

I saw this by downgrading from 1.32.2 to 1.31.1, then upgrading back. But I don't think we care about that.

[DoCode]

@bpasero I can confirm that this issue is fixed in the latest 1.32.2 release! Thanks!

But another one what I noticed:

Steps to reproduce

1. Open VS Code
2. Open one existing document
3. _Optional:_ Open a new tab or new window with a new tab and type anything and do NOT save this new file
4. Close VS Code
5. Re-Open VS Code
6. Now all tabs are correctly restored!
7. Close VS Code
8. Open a File from Windows Explorer with right-click and open in VS Code

Expected behavior

All tabs should re-opened (Tabs/files from Step 2., 3. and 7.)

Actual behavior

Only the unsaved file from step 3. and the one from the Windows Explorer, step 7. are opened.
And the last session (int this example, file from step 1. is lost!

Is this wanted or can this be configured?

[SylwesterZarebski]

Confirm fix and also above bug with 1.32.2 and 1.32.3. Could You report this as new issue?
Now session is partially broken :-(

[DoCode]

@SylwesterZarebski thanks. Please see #70755