Vscode: Using key chord when file tree is focused triggers file highlighting

[pedro-pedrosa]

Issue Type: Bug

When focusing the file tree pane, hitting the "Save all" chord Ctrl+K-S triggers the file highlighting feature when the S key is pressed, making it impossible to use the chord.

VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 10.0.17134

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-4700HQ CPU @ 2.40GHz (8 x 2394)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled|
|Memory (System)|7.89GB (1.75GB free)|
|Process Argv||
|Screen Reader|no|
|VM|50%|

Extensions (3)

Extension|Author (truncated)|Version
---|---|---
tslint|eg2|1.0.42
csharp|ms-|1.17.1
vscode-docker|Pet|0.5.2

[vscodebot[bot]]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Chorded snippets (snippets activated by pressing keys simultaneously) (#46487)
• Emit first key chord when timeout or wrong second key chord (#15550)
• Add suggested completions for key chords (#3969)
• keybindings using [ContextMenu] key sometimes ALSO trigger UI context menu (#47403)
  

[kieferrm]

As a temporary work-around you can disable highlight/filtering in the tree. Change the setting Workbench > List: Keyboard Navigation to simple or in json:

"workbench.list.keyboardNavigation": "simple"

[joaomoreno]

@pedro-pedrosa I can only reproduce if the workbench.list.keyboardNavigation is set to simple. Do you by any chance have that configuration?

[pedro-pedrosa]

Currently set to highlight.

"workbench.list.keyboardNavigation": "highlight"

Anything else you'd like me to check?

[pedro-pedrosa]

If I change it to simple it both triggers the chord and selects a file. If I change it to filter, it doesn't trigger the chord and starts filtering the file tree, same behaviour as highlight.

[IllusionMH]

I'm able to reproduce this issue in latest Insiders build.

1. Click on any file in Explorer
2. Press Ctrl + K - status bar shows (Ctrl + K) was pressed waiting for second key of chord...
3. Press any key - it is added to highlight, status bar still shows (Ctrl + K) was pressed waiting for second key of chord...

I have "workbench.list.keyboardNavigation": "highlight" in settings.

If I switch it to "simple" than I see next behavior:

1. Press Ctrl + K - status bar shows (Ctrl + K) was pressed waiting for second key of chord...
2. Press s - all edited files saved, status bar is cleared and file/folder starting with s is focused

VS Code version: Code - Insiders 1.32.0-insider (1c50a87561055485d93a3961160902308497f1e3, 2019-02-08T06:16:17.233Z)
OS version: Windows_NT x64 10.0.17763

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled|
|Memory (System)|31.88GB (18.29GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

Extensions: none

[webcoderkz]

I've noticed one more thing:

1. If i focus terminal window, and press ⌘K, ⌘S - nothing happens, even if i just press ⌘K i don't see the message ⌘K was pressed waiting for second key of chord..., but if i press ⌘R, then i see the message i mentioned above, but ⌘R, Shift+R doesn't work.
2. if i focus editor window itself, then all keybindings do work.
3. if i focus explorer window, then ⌘K, ⌘S work, but ⌘R, Shift+R doesn't work, it instead highlighting the root folder:

[webcoderkz]

Just checked my keybindings:

As you can see, the When column is empty, so it means these keybindings should fire independent of focused area, e.g. text editor, terminal, explorer. Clearly a bug in 1.31 version.

[alexdima]

I can confirm. Steps:

• define new keybinding, e.g.:

{
    "key": "ctrl+k s",
    "command": "actions.find"
}

• focus the explorer
• press ctrl+k
• the first part of the chord is entered
• press s
• the tree begins to highlight 's'.

---

The workaround provided by kieferrm works for me, which is to define in settings.json:

"workbench.list.keyboardNavigation": "simple"

As @pedro-pedrosa and @IllusionMH note, pressing s for example will trigger the chord and move the focus in the explorer to the first element with s.

---

@heihachi88 Please create a separate issue regarding the terminal. For the explorer, please try the workaround "workbench.list.keyboardNavigation": "simple"

[webcoderkz]

"workbench.list.keyboardNavigation": "simple - it's just a workaround? Things won't change in the future regards this setting?

[pedro-pedrosa]

Disabling features is not a workaround.

[joaomoreno]

I can repro this on Windows, but not on macOS and Linux.

[joaomoreno]

@alexandrudima Check out what I get with Ctrl K.

Ctrl-F17?! :thinking: Investigating...

[joaomoreno]

@alexandrudima Found the issue. I was passing a raw KeyboardEvent to softDispatch which was resolving to that ctrl+F17 keypress. As soon as I wrapped it around StandardKeyboardEvent, I got the correct behavior:

I'll close this with that fix... but you might want to look into it.

[alexdima]

@joaomoreno That is crazy, I didn't realize TS would find those to be compatible... Thanks for the heads up. I've pushed 2ff5d6bec9c0406cf49359a0a92d8a382609b8ef which makes it more obvious and found another bad usage :/ https://github.com/Microsoft/vscode/commit/2ff5d6bec9c0406cf49359a0a92d8a382609b8ef#diff-2203e613237f08bd954dd0a758dfffb4R360