Vscode: Emmet: Wrap with abbreviation in jsx not producing className

[wenfangdu]

Version: 1.30.2 (user setup)
Commit: 61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
Date: 2019-01-07T22:54:13.295Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134

Should produce className not class
Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes

[vscodebot[bot]]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Weird / irrelevant autocomplete (#66613)
• VS Code unusable if too much unused code/transparency in the editor (#63915)
  

[octref]

Context here is React actually uses className instead of class.

[Vinnl]

Note that it did support this behaviour before, and regular Emmet expansions in JSX files _do_ generate className instead of class. In other words: it does look more like a bug than a feature request to me.

(Not sure how much it matters, but just mentioning it to be sure.)

[octref]

I see the problem — completion expands to className, but wrapping doesn't.

[burtek]

Any progress on that? @octref

[octref]

Contribution welcome, otherwise I'll get to this when I have time: https://github.com/Microsoft/vscode/blob/master/extensions/emmet/src/abbreviationActions.ts#L33-L35

[ramya-rao-a]

The link @octref shared is the right place to start for the Wrap with abbreviation feature.

https://github.com/Microsoft/vscode/blob/master/extensions/emmet/src/abbreviationActions.ts#L582 is where one should set a breakpoint to see what is the syntax being returned from the getExpandOptions call. The syntax property should jsx here for emmet to use className and not class

[mattkwiecien]

@ramya-rao-a I'd love to tackle this one if you don't mind.

[mattkwiecien]

@octref Solved and in open PR https://github.com/Microsoft/vscode/pull/68326