Vscode: Pressing . selects the first option in the context menu even before it's opened

[Swazimodo]

Issue Type: Bug

In my react app typing 'this.' will automattically type 'this.UNSAFE_componentWillMount.'. You then have to delete everything after 'this'. After this happens you can press period and you then get the context menu like it should have done initially.

However, this only appears to happen if you type fast. I slowed down a little while doing some further testing and it did not happen.

VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 6.1.7601

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled|
|Memory (System)|31.79GB (14.90GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

Extensions (6)

[jrieken]

This is because of the "editor.acceptSuggestionOnCommitCharacter"-setting. This is what happens

• typing this starts suggesting and the best match is UNSAFE_componentWillMount
• pressing ., with having the aforementioned setting, accepts that suggestion and insert the dot.

Turning the setting to false will get you out of this.

[vscodebot[bot]]

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.

Happy Coding!

[Swazimodo]

If that was the case then why does typing the same thing work if I just do it slightly slower?

[jrieken]

Looks like you have the this suggestion atop then. Not sure why...

[jrieken]

Adding @mjbvz, it seems that the this suggestion disappears while typing...

[alexch]

In JavaScript, when I type cy.get( and then look at the screen I should see cy.get(. Instead I (sometimes!) see crypto.getRandomValues( instead.

This is an #a11y issue; the suggestion menu should not select or fill anything until/unless I press ↓ while it's up. Any setting that takes control away from the user and types extra characters that they did not intend is a bad default setting, and the fact that this behavior is timing-dependent is even more maddening.

Also, the editor.acceptSuggestionOnCommitCharacter sounds like it's intended to type the selected suggestion and a dot when I press ↓., which is actually desirable behavior; the advice to disable editor.acceptSuggestionOnCommitCharacter is more of a workaround than a solution since it disables .-to-accept in all cases, not just this overly-aggressive autocomplete scenario.

Shall I file a new issue or two? Or is this issue sufficient to track both the fact that this setting is wrong by default, and that you might need a new setting e.g. "automaticallySelectFirstSuggestion" (which should also be false by default)?

[mjbvz]

@Swazimodo Do you still see this problem in the latest vscode insiders builds when you fully type out this.?

I've opened https://github.com/Microsoft/TypeScript/issues/30012 to track why this is not suggested first when you type out thi or th, but I can't reproduce the original error in a new create-react-app project

[mjbvz]

I'm closing this issue as I can't repo the issue when fully typing out this.. Microsoft/TypeScript#30012 tracks the root cause of this completions not being properly sorted before you fully type out this.