Vscode: JSX tag highlighting broken

[BrentonWatt]

• VSCode Version: 1.30
• OS Version: Mac OS 10.14.2

Previously when selecting an opening tag in any JSX only the corresponding closing tag would be highlighted. As of version 1.30 (November) ALL corresponding JSX tags are highlighted across the file. I.e If you select any opening View tag for example, all View tags across the file are highlighted. It's almost like the tags are being treated like variables.

Steps to Reproduce:

1. Open any JS file with JSX, in my case I was working with React Native JSX
2. Click on any opening tag

Does this issue occur when all extensions are disabled?: Yes

[vscodebot[bot]]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• In JSX does not create new line between tags with right indentation after heating enter (#61954)
• use language server for onEnterRules (#57968)
• Jsx code highlight error (#61422)
• Smart Bracket matching for different start tags with the same end tag does not work properly. (#53134)
• Tab / auto tag completion incorrectly adds closing tag when pasting text in jsx file (#62893)
  

[sunnyday90210]

• VSCodeInsiders Version: 1.31.0-insider (user setup)
• Windows 10 Pro: 10.0.17763 Build 17763

I am experiencing the same issue.
When highlighting any tags in the jsx file vscode seems to select all corresponding tags that are the same.

Small workaround for now until this is fixed I am using Highlight Matching Tag it supports jsx.

[Muljayan]

I have the same issue when working with a plain react app. I am using Ubuntu 18.10 .

[sjnonweb]

Confirming the same! Tried disabling/uninstalling all extensions still this issue is happening. For now i have rolled back to 1.29.1

[mjbvz]

Actually this, may be a VS Code api usage issue. We changed to use references for highlighting since the occurrences api is marked deprecated

@DanielRosenwasser Opinions on the what we should do here?

[DanielRosenwasser]

I don't think that there's a practical difference; getOccurrencesAtPosition just filters out entries that didn't come from the file being asked about. For all intents and purposes, it's the same as getDocumentHighlights with a different output format. It's only a legacy API because old versions of Visual Studio were throwing exceptions for spans outside the current file.

[onur-dev]

Same problem here...

[uniqueiniquity]

@mjbvz it seems like you should be using documentHighlights rather than references here; this particular issue is explicitly handled already. Is there a particular reason you're inclined to use references instead?

[DanielRosenwasser]

Oh jeez, yes. Ben is right. Otherwise you're missing out on some handy specific functionality that we did for occurrences/documentHighlights.

[mjbvz]

Thanks @DanielRosenwasser. Didn't realize this TS Server API existed. I'll update VS Code to use it

[Muljayan]

@mjbvz @DanielRosenwasser I am still getting this issue on Ubuntu 18.10 , vs-code version 1.30.2. Is the fix scheduled to be in a later update ?

[vrubliuk]

The same issue is on Windows 10, (VS code 1.30.2)

[7nights]

Still having this issue on Mac, VS Code 1.30.2.
Just reverted to 1.29 and tag matching works fine for me. @Muljayan @vrubliuk

[DanielRosenwasser]

It's been 13 days since the fix - just use the insiders releases in the meantime.

[7nights]

@DanielRosenwasser As for a software that needs to be used at daily work, pushing user into insiders channel is not a good idea. I think you should never tell people to switch to a insiders release for getting a fix (because they may get several new bugs at the same time), instead you should release a patch to the stable channel. After all it has been one and a half month since the bug was released 😢

[Muljayan]

This is fixed in the latest updated.