Vscode: Allow for rendering at high frame rates

Created on 15 Dec 2018  路  7Comments  路  Source: microsoft/vscode

Version: 1.30.0
Commit: c6e592b2b5770e40a98cb9c2715a8ef89aec3d74
Date: 2018-12-11T22:21:33.585Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Linux x64 4.18.20-gentoo
Graphics driver: amdgpu

I have done some rudimentary testing, and I have concluded that VS Code does not render above 60 frames per second. I recently enabled smooth selection caret rendering, and I noticed that for moving to the end of longer lines, the number of frames rendered are about half or less than what is rendered by my mouse going at the same distance and speed. I have a 144hz monitor, and 144 is more than double 60, which would confirm my test results.

Additionally, I can get 144 frames per second in Chrome, tested via https://www.testufo.com/ and compared with Firefox running at 60 frames per second.

What I would like is the possibility of rendering VS Code at a frame rate higher than 60. This would of course only be expected with GPU rendering.

*out-of-scope editor-rendering feature-request

Most helpful comment

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430

Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

All 7 comments

still no status?

We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430

Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

I for one would really like to see VS Code respect refresh rates higher than 60hz. I cringe whenever I need to switch over to VS Code from PhpStorm on my 144hz monitor.

I'd even be happy with 100 FPS if it's a performance issue. Or allow the FPS cap to be configured for "power" users. Or use requestAnimationFrame() like it's not the 20th century. Or something!

If you're still looking for a solution, adding these settings to settings.json should do the trick.

  "editor.smoothScrolling": true,
  "editor.cursorSmoothCaretAnimation": true,
  "workbench.list.smoothScrolling": true,

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430

Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

im a starter user, how i can get at vscode/src/vs/base/browser/dom.ts, ive searched this path and i cant find

@LukGaming I assume you would need to clone the repo, make that modification, and build VSCode from scratch. It's more of a POC than a solution.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

trstringer picture trstringer  路  3Comments

omidgolparvar picture omidgolparvar  路  3Comments

philipgiuliani picture philipgiuliani  路  3Comments

biij5698 picture biij5698  路  3Comments

sijad picture sijad  路  3Comments