Vscode: Escapce to dismiss terminal find widget doesn't refocus the terminal

[rebornix]

59267

• Open the terminal, search
• Escape to dismiss the find widget
• The terminal doesn't regain the focus

[TomerPacific]

@Tyriar ,
Is this issue still relevant and if so, can I try to solve it?

[Tyriar]

@TomerPacific still needed yes, code pointer:

https://github.com/Microsoft/vscode/blob/0e7b34db425af89c86c41abc9371903d19e4e476/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts#L478-L481

Help would be greatly appreciated 😃

[TomerPacific]

@Tyriar ,
sorry to bother you, but I am having trouble just setting up the project. I am using a Windows 7, 64bit machine, and after I cloned the repository and ran yarn, I keep getting issues regarding vscode-fsevents. It says that the platform win32 is not compatible with this module. I have read about this online and have not found any possible solutions. I'd appreciate your feedback into what I can do as I am stuck and cannot even build the project in order to see the aforementioned bug happening. Thanks.

[tmax]

what version exactly is this tied to? I do not see it in my current environment:

I'm on:

```
Version 1.28.1 (1.28.1)

3368db6750222d319c851f6d90eb619d886e08f5

2018-10-11T18:00:44.561Z
```

Mac OS: 10.11.6 (15G22010)

Is this an issue only in a particular build and/or os version?

[tmax]

I also just build the latest master cdabfc35e0795e7c734358db040693354e7ae41a I _cannot_ reproduce the issue that is described here.

same OS information as mentioned in my previous comment https://github.com/Microsoft/vscode/issues/59388#issuecomment-429554522.

Can we close this issue? Seems to not be a bug at least on the latest build.

[tmax]

Also, in case this is an issue in a particular version, do you mind listing the OS/platform and commit hash or VS Code version where you encountered this bug @rebornix ?

[tmax]

this is kind of related, and I'm assuming a few things here, so correct me if I'm wrong, but.... should vscodebod app have _not_ filed this issue? It seems there are some vital informations missing from the ticket description in order to pinpoint exactly how and where to find the bug here.

cc @Tyriar ?

[Tyriar]

I keep getting issues regarding vscode-fsevents. It says that the platform win32 is not compatible with this module.

@TomerPacific you can safely ignore that, it just means yarn skipped the installation.

Can we close this issue? Seems to not be a bug at least on the latest build.

Someone else must have fixed this over the past couple of days, it was definitely happening when I added the labels 😕. Thanks for pointing it out.

[tmax]

Just curious, but do you happen to know which issue it was fixed in?

[TomerPacific]

@Tyriar ,
any other beginner issues I can help with?

[Tyriar]

@TomerPacific https://github.com/Microsoft/vscode/labels/good%20first%20issue is the list of beginner stuff available, the more general query https://github.com/Microsoft/vscode/labels/help%20wanted has all the changes we want help but and may also have some easy ones.

[Tyriar]

@tmax not sure, don't think it's worth the time to investigate.