Vscode: Give the option to fix centered layout width.

Created on 20 Jul 2018  路  14Comments  路  Source: microsoft/vscode

Previously the centered layout in zen mode had a fixed width, meaning that if you resize the window the centered section will remain the same as long as it still fits in the resized window. The behaviour now is for the centered section width to be proportional to the size of the window. See below:

image

On resize, old behaviour/new behaviour:

image

feature-request help wanted workbench-zen

Most helpful comment

Yes I can reopen.

All 14 comments

This is a fair feature request. I know @joaomoreno wanted something like this.

I agree, having the editor window resized every time you toggle sidebar is quite annoying for me. It would also be nice to bring back switching back to full-size layout when having more than 1 editor open side by side.

@isidorn I think this issue is closely related to #53989

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

So does this mean that you're not going to address this issue any time in the near future? "Issue grooming" seems to simply be a euphemism for getting rid of issues that nobody wants to fix.

Can this be reopened? I feel this would be a great change

Yes I can reopen.

@isidorn Thanks a lot!

Any plans on implementing this?

I love the centered layout feature and I _really_ want to be able to use it. Unfortunately it's unusable as is and I've avoided it for the last couple of years waiting for it to be addressed.

First and foremost, the size must be absolute, not relative. The current behavior is honestly just broken. I can't think of a sane reason why it would be relative. Look at the results:

Sane:
image

Not sane:
image

This is also being asked for here: https://github.com/microsoft/vscode/issues/71361#issuecomment-491854562

Second, we need settings for whether to use centered layout and to set the default size. I put in a request for this years ago and it was inexplicably renamed to a completely different request and closed as a duplicate.

P.S. I'm now noticing it's even not centered properly? That's weird...

This is a fair feature request and we are open for a lean and good PR that fixes this
Code pointer https://github.com/microsoft/vscode/blob/b7a9bfa7f9e8d34414b1319ff214eb8a2f55c524/src/vs/base/browser/ui/centered/centeredViewLayout.ts#L65

Any plans on implementing this?

Looks like somebody already implemented a PR for it (#104942), but the vscode people decided to close it for petty reasons.

Was this page helpful?
0 / 5 - 0 ratings